CreateUserHandlerTest::testCreateUserGetsHandled() - Code Metrics - Inspection of "51 add a cli tool to easily add manage users" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

unknown

created 2016-06-07 15:31 UTC

CreateUserHandlerTest::testCreateUserGetsHandled() B

↳ Parent: CreateUserHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	24
rs	8.9713
cc	1
eloc	16
nc	1
nop	0

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;

use SumoCoders\FrameworkMultiUserBundle\Command\CreateUser;
use SumoCoders\FrameworkMultiUserBundle\Command\CreateUserHandler;
use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;

class CreateUserHandlerTest extends \PHPUnit_Framework_TestCase
{
    private $userRepository;

    public function setUp()
    {
        $this->userRepository = new InMemoryUserRepository();
    }

    /**
     * Test if CreateUserHandler gets handled.
     */
    public function testCreateUserGetsHandled()
    {
        $handler = new CreateUserHandler($this->userRepository);

        $user = new CreateUser();
        $user->username = 'sumo';
        $user->displayName = 'sumocoders';
        $user->password = 'randomPassword';

        $handler->handle($user);

        $this->assertEquals(
            'sumo',
            $this->userRepository->findByUsername('sumo')->getUsername()
        );
        $this->assertEquals(
            'sumocoders',
            $this->userRepository->findByUsername('sumo')->getDisplayName()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
        $this->assertEquals(
            'randomPassword',
            $this->userRepository->findByUsername('sumo')->getPassword()
        );
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\Command\CreateUser;
6			use SumoCoders\FrameworkMultiUserBundle\Command\CreateUserHandler;
7			use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
8
9			class CreateUserHandlerTest extends \PHPUnit_Framework_TestCase
10			{
11			private $userRepository;
12
13			public function setUp()
14			{
15			$this->userRepository = new InMemoryUserRepository();
16			}
17
18			/**
19			* Test if CreateUserHandler gets handled.
20			*/
21			public function testCreateUserGetsHandled()
22			{
23			$handler = new CreateUserHandler($this->userRepository);
24
25			$user = new CreateUser();
26			$user->username = 'sumo';
27			$user->displayName = 'sumocoders';
28			$user->password = 'randomPassword';
29
30			$handler->handle($user);
31
32			$this->assertEquals(
33			'sumo',
34			$this->userRepository->findByUsername('sumo')->getUsername()
35			);
36			$this->assertEquals(
37			'sumocoders',
38			$this->userRepository->findByUsername('sumo')->getDisplayName()
			0 ignored issues – show Bug introduced 2016-06-07 15:40 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Security\Core\User\UserInterface` as the method `getDisplayName()` does only exist in the following implementations of said interface: `SumoCoders\FrameworkMultiUserBundle\User\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
39			);
40			$this->assertEquals(
41			'randomPassword',
42			$this->userRepository->findByUsername('sumo')->getPassword()
43			);
44			}
45			}
46

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#10)

CreateUserHandlerTest::testCreateUserGetsHandled() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like