PasswordResetRequestHandler::sendPasswordResetToken() - Code Metrics - Inspection of "54 add forgot password" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2016-06-15 07:49 UTC

sendPasswordResetToken() A

↳ Parent: PasswordResetRequestHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	12
rs	9.4285
cc	1
eloc	8
nc	1
nop	1

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Command;

use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
use Swift_Mailer;
use Swift_Message;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\Translation\TranslatorInterface;

class PasswordResetRequestHandler
{
    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    /**
     * @var Swift_Mailer
     */
    private $mailer;

    /**
     * @var TranslatorInterface
     */
    private $translator;

    /**
     * @var RouterInterface
     */
    private $router;

    public function __construct(UserRepositoryCollection $userRepositoryCollection, Swift_Mailer $mailer, TranslatorInterface $translator, RouterInterface $router)
    {
        $this->userRepositoryCollection = $userRepositoryCollection;
        $this->mailer = $mailer;
        $this->translator = $translator;
        $this->router = $router;
    }

    /**
     * Creates a password reset token and sends an email to the user.
     *
     * @param PasswordResetRequest $command
     *
     * @return int
     */
    public function handle(PasswordResetRequest $command)
    {
        $user = $command->getUser();
        $user->generatePasswordResetToken();
        $repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
        $repository->save($user);

        return $this->sendPasswordResetToken($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Sends the password reset token to the user.
     *
     * @param UserPasswordReset $user
     *
     * @return int
     */
    private function sendPasswordResetToken(UserPasswordReset $user)
    {
        $messageBody = $this->getPasswordResetMessage($user);

        $message = Swift_Message::newInstance()
            ->setSubject('Password reset requested')
            ->setFrom('[email protected]')
            ->setTo($user->getEmail())
            ->setBody($messageBody, 'text/plain');

        return $this->mailer->send($message);
    }

    /**
     * Creates the password reset message.
     *
     * @param UserPasswordReset $user
     *
     * @return string
     */
    private function getPasswordResetMessage(UserPasswordReset $user)
    {
        $url = $this->router->generate('multi_user_reset_password', [], true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $token = '?token='.urlencode($user->getPasswordResetToken());

        return $this->translator->trans('sumocoders.multiuserbundle.mail.request_password', ['%link%' => $url.$token]);
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
6			use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
7			use Swift_Mailer;
8			use Swift_Message;
9			use Symfony\Component\Routing\RouterInterface;
10			use Symfony\Component\Translation\TranslatorInterface;
11
12			class PasswordResetRequestHandler
13			{
14			/**
15			* @var UserRepositoryCollection
16			*/
17			private $userRepositoryCollection;
18
19			/**
20			* @var Swift_Mailer
21			*/
22			private $mailer;
23
24			/**
25			* @var TranslatorInterface
26			*/
27			private $translator;
28
29			/**
30			* @var RouterInterface
31			*/
32			private $router;
33
34			public function __construct(UserRepositoryCollection $userRepositoryCollection, Swift_Mailer $mailer, TranslatorInterface $translator, RouterInterface $router)
35			{
36			$this->userRepositoryCollection = $userRepositoryCollection;
37			$this->mailer = $mailer;
38			$this->translator = $translator;
39			$this->router = $router;
40			}
41
42			/**
43			* Creates a password reset token and sends an email to the user.
44			*
45			* @param PasswordResetRequest $command
46			*
47			* @return int
48			*/
49			public function handle(PasswordResetRequest $command)
50			{
51			$user = $command->getUser();
52			$user->generatePasswordResetToken();
53			$repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
54			$repository->save($user);
55
56			return $this->sendPasswordResetToken($user);
			0 ignored issues – show Documentation introduced 2016-06-15 07:06 UTC by Report Bug Copy Issue Report `$user` is of type `object<SumoCoders\Framew...dle\User\UserInterface>`, but the function expects a `object<SumoCoders\Framew...dle\User\PasswordReset>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57			}
58
59			/**
60			* Sends the password reset token to the user.
61			*
62			* @param UserPasswordReset $user
63			*
64			* @return int
65			*/
66			private function sendPasswordResetToken(UserPasswordReset $user)
67			{
68			$messageBody = $this->getPasswordResetMessage($user);
69
70			$message = Swift_Message::newInstance()
71			->setSubject('Password reset requested')
72			->setFrom('[email protected]')
73			->setTo($user->getEmail())
74			->setBody($messageBody, 'text/plain');
75
76			return $this->mailer->send($message);
77			}
78
79			/**
80			* Creates the password reset message.
81			*
82			* @param UserPasswordReset $user
83			*
84			* @return string
85			*/
86			private function getPasswordResetMessage(UserPasswordReset $user)
87			{
88			$url = $this->router->generate('multi_user_reset_password', [], true);
			0 ignored issues – show Documentation introduced 2016-06-14 15:12 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89			$token = '?token='.urlencode($user->getPasswordResetToken());
90
91			return $this->translator->trans('sumocoders.multiuserbundle.mail.request_password', ['%link%' => $url.$token]);
92			}
93			}
94

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#12)

sendPasswordResetToken() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like