SumoCoders\FrameworkMultiUserBundle\Tests\Command\UpdateUserHandlerTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	5
Bugs	1	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
B	testUpdateUserGetsHandled()	0	31	1

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;

use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser;
use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUserHandler;
use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;

class UpdateUserHandlerTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    public function setUp()
    {
        $this->userRepository = new InMemoryUserRepository();
        $this->userRepositoryCollection = new UserRepositoryCollection([$this->userRepository]);
    }

    /**
     * Test if UpdateUserHandler gets handled.
     */
    public function testUpdateUserGetsHandled()
    {
        $handler = new UpdateUserHandler($this->userRepositoryCollection);

        $updatingUser = $this->userRepository->findByUsername('wouter');

        $command = new UpdateUser($updatingUser, 'wouter', 'randomPassword', 'sumocoders');

It seems like $updatingUser defined by $this->userRepository->findByUsername('wouter') on line 36 can be null; however, SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser::__construct() does not accept null, maybe add an additional type check?

        $handler->handle($command);

        $this->assertEquals(
            'wouter',
            $this->userRepository->findByUsername('wouter')->getUsername()
        );
        $this->assertEquals(
            'sumocoders',
            $this->userRepository->findByUsername('wouter')->getDisplayName()
        );
        $this->assertEquals(
            'randomPassword',
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
        $this->assertNotEquals(
            $updatingUser->getDisplayName(),
            $this->userRepository->findByUsername('wouter')->getDisplayName()
        );
        $this->assertNotEquals(
            $updatingUser->getPassword(),
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
    }
}