Completed
Pull Request — master (#10)
by
unknown
05:39 queued 02:04
created

DeleteUserCommand   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 70
Duplicated Lines 30 %

Coupling/Cohesion

Components 1
Dependencies 4

Importance

Changes 6
Bugs 0 Features 1
Metric Value
wmc 5
c 6
b 0
f 1
lcom 1
cbo 4
dl 21
loc 70
rs 10

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A configure() 0 19 1
A execute() 21 21 2
A getRepository() 0 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace SumoCoders\FrameworkMultiUserBundle\Command;
4
5
use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
6
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
7
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
8
use Symfony\Component\Console\Input\InputArgument;
9
use Symfony\Component\Console\Input\InputInterface;
10
use Symfony\Component\Console\Input\InputOption;
11
use Symfony\Component\Console\Output\OutputInterface;
12
13
final class DeleteUserCommand extends ContainerAwareCommand
14
{
15
    /**
16
     * @var UserRepositoryCollection
17
     */
18
    private $userRepositoryCollection;
19
20
    /**
21
     * @param UserRepositoryCollection $userRepositoryCollection
22
     */
23
    public function __construct(UserRepositoryCollection $userRepositoryCollection)
24
    {
25
        parent::__construct();
26
        $this->userRepositoryCollection = $userRepositoryCollection;
27
    }
28
    
29
    protected function configure()
30
    {
31
        $this
32
            ->setName('sumocoders:multiuser:delete')
33
            ->setDescription('Delete a user entity')
34
            ->addArgument(
35
                'username',
36
                InputArgument::REQUIRED,
37
                'The username of the user'
38
            )
39
            ->addOption(
40
                'class',
41
                null,
42
                InputOption::VALUE_OPTIONAL,
43
                'The class off the user',
44
                'SumoCoders\FrameworkMultiUserBundle\User\User'
45
            )
46
        ;
47
    }
48
49 View Code Duplication
    protected function execute(InputInterface $input, OutputInterface $output)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
50
    {
51
        $userClass = $input->getOption('class');
52
53
        $repository = $this->getRepository($userClass);
54
        
55
        $username = $input->getArgument('username');
56
        $user = $repository->findByUsername($username);
57
58
        if (!$user) {
59
            $output->writeln('<error>'.$username.' doesn\'t exists');
60
            return;
61
        }
62
63
        $command = new DeleteUser($user);
0 ignored issues
show
Compatibility introduced by
$user of type object<Symfony\Component...ore\User\UserInterface> is not a sub-type of object<SumoCoders\Framew...tiUserBundle\User\User>. It seems like you assume a concrete implementation of the interface Symfony\Component\Security\Core\User\UserInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
64
        
65
        $handler = new DeleteUserHandler($repository);
66
        $handler->handle($command);
67
68
        $output->writeln($username . ' has been deleted');
69
    }
70
71
    /**
72
     * Get the repository for the user's Class.
73
     *
74
     * @param $userClass
75
     *
76
     * @return UserRepository
77
     */
78
    private function getRepository($userClass)
79
    {
80
        return $this->userRepositoryCollection->findRepositoryByClassName($userClass);
81
    }
82
}
83