UpdateUserHandlerTest::testUpdateUserGetsHandled() - Code Metrics - Inspection of "51 add a cli tool to easily add manage users" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

unknown

created 2016-06-10 06:43 UTC

UpdateUserHandlerTest::testUpdateUserGetsHandled() B

↳ Parent: UpdateUserHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	31
rs	8.8571
cc	1
eloc	20
nc	1
nop	0

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;

use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser;
use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUserHandler;
use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;

class UpdateUserHandlerTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    public function setUp()
    {
        $this->userRepository = new InMemoryUserRepository();
    }

    /**
     * Test if UpdateUserHandler gets handled.
     */
    public function testUpdateUserGetsHandled()
    {
        $handler = new UpdateUserHandler($this->userRepository);

        $updatingUser = $this->userRepository->findByUsername('wouter');

        $command = new UpdateUser($updatingUser, 'wouter', 'randomPassword', 'sumocoders');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $handler->handle($command);

        $this->assertEquals(
            'wouter',
            $this->userRepository->findByUsername('wouter')->getUsername()
        );
        $this->assertEquals(
            'sumocoders',
            $this->userRepository->findByUsername('wouter')->getDisplayName()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
        $this->assertEquals(
            'randomPassword',
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
        $this->assertNotEquals(
            $updatingUser->getDisplayName(),
            $this->userRepository->findByUsername('wouter')->getDisplayName()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
        $this->assertNotEquals(
            $updatingUser->getPassword(),
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
    }
}


Pull Request — master (#10)

UpdateUserHandlerTest::testUpdateUserGetsHandled() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser;
6			use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUserHandler;
7			use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
8			use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
9
10			class UpdateUserHandlerTest extends \PHPUnit_Framework_TestCase
11			{
12			/**
13			* @var UserRepository
14			*/
15			private $userRepository;
16
17			public function setUp()
18			{
19			$this->userRepository = new InMemoryUserRepository();
20			}
21
22			/**
23			* Test if UpdateUserHandler gets handled.
24			*/
25			public function testUpdateUserGetsHandled()
26			{
27			$handler = new UpdateUserHandler($this->userRepository);
28
29			$updatingUser = $this->userRepository->findByUsername('wouter');
30
31			$command = new UpdateUser($updatingUser, 'wouter', 'randomPassword', 'sumocoders');
			0 ignored issues – show Documentation introduced 2016-06-08 07:38 UTC by Report Bug Copy Issue Report `$updatingUser` is of type `object<Symfony\Component...ser\UserInterface>\|null`, but the function expects a `object<SumoCoders\Framew...tiUserBundle\User\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			$handler->handle($command);
34
35			$this->assertEquals(
36			'wouter',
37			$this->userRepository->findByUsername('wouter')->getUsername()
38			);
39			$this->assertEquals(
40			'sumocoders',
41			$this->userRepository->findByUsername('wouter')->getDisplayName()
			0 ignored issues – show Bug introduced 2016-06-09 13:59 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Security\Core\User\UserInterface` as the method `getDisplayName()` does only exist in the following implementations of said interface: `SumoCoders\FrameworkMultiUserBundle\User\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
42			);
43			$this->assertEquals(
44			'randomPassword',
45			$this->userRepository->findByUsername('wouter')->getPassword()
46			);
47			$this->assertNotEquals(
48			$updatingUser->getDisplayName(),
49			$this->userRepository->findByUsername('wouter')->getDisplayName()
			0 ignored issues – show Bug introduced 2016-06-09 13:59 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Security\Core\User\UserInterface` as the method `getDisplayName()` does only exist in the following implementations of said interface: `SumoCoders\FrameworkMultiUserBundle\User\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
50			);
51			$this->assertNotEquals(
52			$updatingUser->getPassword(),
53			$this->userRepository->findByUsername('wouter')->getPassword()
54			);
55			}
56			}
57

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#10)

UpdateUserHandlerTest::testUpdateUserGetsHandled() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like