SumoCoders\FrameworkMultiUserBundle\Command\DeleteUserCommand

Complexity

Total Complexity

9

Size/Duplication

Total Lines	107
Duplicated Lines	48.6 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	8
Bugs	0	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getRepository()	0	4	1
A	__construct()	0	5	1
A	configure()	0	19	1
B	execute()	39	39	4
A	getAllValidUserClasses()	13	13	2

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Command;

use SumoCoders\FrameworkMultiUserBundle\Exception\NoRepositoriesRegisteredException;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;

final class DeleteUserCommand extends Command
{
    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    /**
     * @param UserRepositoryCollection $userRepositoryCollection
     */
    public function __construct(UserRepositoryCollection $userRepositoryCollection)
    {
        parent::__construct();
        $this->userRepositoryCollection = $userRepositoryCollection;
    }

    protected function configure()
    {
        $this
            ->setName('sumocoders:multiuser:delete')
            ->setDescription('Delete a user entity')
            ->addArgument(
                'username',
                InputArgument::REQUIRED,
                'The username of the user'
            )
            ->addOption(
                'class',
                null,
                InputOption::VALUE_OPTIONAL,
                'The class off the user',
                'SumoCoders\FrameworkMultiUserBundle\User\User'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)

This method seems to be duplicated in your project.

    {
        $userClass = $input->getOption('class');

        $availableUserClasses = $this->getAllValidUserClasses();

        if (count($availableUserClasses) == 1) {
            $userClass = $availableUserClasses[0];
        }

        if (!isset($userClass)) {
            $helper = $this->getHelper('question');
            $question = new ChoiceQuestion(
                'Please select the user class',
                $availableUserClasses,
                0
            );

            $userClass = $helper->ask($input, $output, $question);
        }

        $repository = $this->getRepository($userClass);

        $username = $input->getArgument('username');
        $user = $repository->findByUsername($username);

        if (!$user) {
            $output->writeln('<error>'.$username.' doesn\'t exists');

            return;
        }

        $command = new DeleteUser($user);

$user of type object<Symfony\Component\Security\Core\User\UserInterface> is not a sub-type of object<SumoCoders\FrameworkMultiUserBundle\User\User>. It seems like you assume a concrete implementation of the interface Symfony\Component\Security\Core\User\UserInterface to be always present.

        $handler = new DeleteUserHandler($repository);
        $handler->handle($command);

        $output->writeln($username . ' has been deleted');
    }

    /**
     * @throws NoRepositoriesRegisteredException
     *
     * @return array
     */
    private function getAllValidUserClasses()

This method seems to be duplicated in your project.

    {
        if (count($this->userRepositoryCollection->all()) === 0) {
            throw new NoRepositoriesRegisteredException('No user repositories registered');
        }

        return array_map(
            function (UserRepository $repository) {
                return $repository->getSupportedClass();
            },
            $this->userRepositoryCollection->all()
        );
    }

    /**
     * Get the repository for the user's Class.
     *
     * @param $userClass
     *
     * @return UserRepository
     */
    private function getRepository($userClass)
    {
        return $this->userRepositoryCollection->findRepositoryByClassName($userClass);
    }
}