PasswordResetRequestHandler::__construct() - Code Metrics - Inspection of "54 add forgot password" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2016-06-15 12:38 UTC

PasswordResetRequestHandler::__construct() A

↳ Parent: PasswordResetRequestHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	9
rs	9.6666
cc	1
eloc	7
nc	1
nop	3

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Command;

use SumoCoders\FrameworkMultiUserBundle\Event\OnPasswordResetTokenCreated;
use SumoCoders\FrameworkMultiUserBundle\Event\PasswordResetTokenCreated;
use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
use Swift_Mailer;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class PasswordResetRequestHandler
{
    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    /**
     * @var Swift_Mailer
     */
    private $listener;

    /**
     * @var EventDispatcher
     */
    private $dispatcher;

    /**
     * PasswordResetRequestHandler constructor.
     *
     * @param UserRepositoryCollection $userRepositoryCollection
     * @param EventDispatcherInterface $dispatcher
     * @param OnPasswordResetTokenCreated $listener
     */
    public function __construct(
        UserRepositoryCollection $userRepositoryCollection,
        EventDispatcherInterface $dispatcher,
        OnPasswordResetTokenCreated $listener
    ) {
        $this->userRepositoryCollection = $userRepositoryCollection;
        $this->dispatcher = $dispatcher;

        $this->listener = $listener;

    }

    /**
     * Creates a password reset token and sends an email to the user.
     *
     * @param RequestPasswordReset $command
     *
     * @return int
     */
    public function handle(RequestPasswordReset $command)
    {
        $user = $command->getUser();
        $user->generatePasswordResetToken();
        $repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
        $repository->save($user);

        $this->sendPasswordResetToken($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Sends the password reset token to the user.
     *
     * @param UserPasswordReset $user
     *
     * @return int
     */
    private function sendPasswordResetToken(UserPasswordReset $user)
    {
        $event = new PasswordResetTokenCreated($user);
        $this->dispatcher->addListener(PasswordResetTokenCreated::NAME, [$this->listener, 'onPasswordResetTokenCreated']);
        $this->dispatcher->dispatch('multi_user.event.password_reset_token_created', $event);
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\Event\OnPasswordResetTokenCreated;
6			use SumoCoders\FrameworkMultiUserBundle\Event\PasswordResetTokenCreated;
7			use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
8			use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
9			use Swift_Mailer;
10			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
11
12			class PasswordResetRequestHandler
13			{
14			/**
15			* @var UserRepositoryCollection
16			*/
17			private $userRepositoryCollection;
18
19			/**
20			* @var Swift_Mailer
21			*/
22			private $listener;
23
24			/**
25			* @var EventDispatcher
26			*/
27			private $dispatcher;
28
29			/**
30			* PasswordResetRequestHandler constructor.
31			*
32			* @param UserRepositoryCollection $userRepositoryCollection
33			* @param EventDispatcherInterface $dispatcher
34			* @param OnPasswordResetTokenCreated $listener
35			*/
36			public function __construct(
37			UserRepositoryCollection $userRepositoryCollection,
38			EventDispatcherInterface $dispatcher,
39			OnPasswordResetTokenCreated $listener
40			) {
41			$this->userRepositoryCollection = $userRepositoryCollection;
42			$this->dispatcher = $dispatcher;
			0 ignored issues – show Documentation Bug introduced 2016-06-15 12:41 UTC by Report Bug Copy Issue Report It seems like `$dispatcher` of type `object<Symfony\Component...entDispatcherInterface>` is incompatible with the declared type `object<SumoCoders\Framew...ommand\EventDispatcher>` of property `$dispatcher`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43			$this->listener = $listener;
			0 ignored issues – show Documentation Bug introduced 2016-06-15 12:41 UTC by Report Bug Copy Issue Report It seems like `$listener` of type `object<SumoCoders\Framew...swordResetTokenCreated>` is incompatible with the declared type `object<Swift_Mailer>` of property `$listener`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
44			}
45
46			/**
47			* Creates a password reset token and sends an email to the user.
48			*
49			* @param RequestPasswordReset $command
50			*
51			* @return int
52			*/
53			public function handle(RequestPasswordReset $command)
54			{
55			$user = $command->getUser();
56			$user->generatePasswordResetToken();
57			$repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
58			$repository->save($user);
59
60			$this->sendPasswordResetToken($user);
			0 ignored issues – show Documentation introduced 2016-06-15 07:06 UTC by Report Bug Copy Issue Report `$user` is of type `object<SumoCoders\Framew...dle\User\UserInterface>`, but the function expects a `object<SumoCoders\Framew...dle\User\PasswordReset>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62
63			/**
64			* Sends the password reset token to the user.
65			*
66			* @param UserPasswordReset $user
67			*
68			* @return int
69			*/
70			private function sendPasswordResetToken(UserPasswordReset $user)
71			{
72			$event = new PasswordResetTokenCreated($user);
73			$this->dispatcher->addListener(PasswordResetTokenCreated::NAME, [$this->listener, 'onPasswordResetTokenCreated']);
74			$this->dispatcher->dispatch('multi_user.event.password_reset_token_created', $event);
75			}
76			}
77

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#12)

PasswordResetRequestHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like