UpdateUserHandlerTest::testUpdateUserGetsHandled() - Code Metrics - Inspection of "51 add a cli tool to easily add manage users" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

unknown

created 2016-06-10 12:19 UTC

UpdateUserHandlerTest::testUpdateUserGetsHandled() B

↳ Parent: UpdateUserHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	31
rs	8.8571
cc	1
eloc	20
nc	1
nop	0

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;

use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser;
use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUserHandler;
use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;

class UpdateUserHandlerTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    public function setUp()
    {
        $this->userRepository = new InMemoryUserRepository();
        $this->userRepositoryCollection = new UserRepositoryCollection([$this->userRepository]);
    }

    /**
     * Test if UpdateUserHandler gets handled.
     */
    public function testUpdateUserGetsHandled()
    {
        $handler = new UpdateUserHandler($this->userRepositoryCollection);

        $updatingUser = $this->userRepository->findByUsername('wouter');

        $command = new UpdateUser($updatingUser, 'wouter', 'randomPassword', 'sumocoders');
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $handler->handle($command);

        $this->assertEquals(
            'wouter',
            $this->userRepository->findByUsername('wouter')->getUsername()
        );
        $this->assertEquals(
            'sumocoders',
            $this->userRepository->findByUsername('wouter')->getDisplayName()
        );
        $this->assertEquals(
            'randomPassword',
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
        $this->assertNotEquals(
            $updatingUser->getDisplayName(),
            $this->userRepository->findByUsername('wouter')->getDisplayName()
        );
        $this->assertNotEquals(
            $updatingUser->getPassword(),
            $this->userRepository->findByUsername('wouter')->getPassword()
        );
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Tests\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUser;
6			use SumoCoders\FrameworkMultiUserBundle\Command\UpdateUserHandler;
7			use SumoCoders\FrameworkMultiUserBundle\User\InMemoryUserRepository;
8			use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
9			use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
10
11			class UpdateUserHandlerTest extends \PHPUnit_Framework_TestCase
12			{
13			/**
14			* @var UserRepository
15			*/
16			private $userRepository;
17
18			/**
19			* @var UserRepositoryCollection
20			*/
21			private $userRepositoryCollection;
22
23			public function setUp()
24			{
25			$this->userRepository = new InMemoryUserRepository();
26			$this->userRepositoryCollection = new UserRepositoryCollection([$this->userRepository]);
27			}
28
29			/**
30			* Test if UpdateUserHandler gets handled.
31			*/
32			public function testUpdateUserGetsHandled()
33			{
34			$handler = new UpdateUserHandler($this->userRepositoryCollection);
35
36			$updatingUser = $this->userRepository->findByUsername('wouter');
37
38			$command = new UpdateUser($updatingUser, 'wouter', 'randomPassword', 'sumocoders');
			0 ignored issues – show Bug introduced 2016-06-10 12:28 UTC by Report Bug Copy Issue Report It seems like `$updatingUser` defined by `$this->userRepository->findByUsername('wouter')` on line `36` can be `null`; however, `SumoCoders\FrameworkMult...dateUser::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
39
40			$handler->handle($command);
41
42			$this->assertEquals(
43			'wouter',
44			$this->userRepository->findByUsername('wouter')->getUsername()
45			);
46			$this->assertEquals(
47			'sumocoders',
48			$this->userRepository->findByUsername('wouter')->getDisplayName()
49			);
50			$this->assertEquals(
51			'randomPassword',
52			$this->userRepository->findByUsername('wouter')->getPassword()
53			);
54			$this->assertNotEquals(
55			$updatingUser->getDisplayName(),
56			$this->userRepository->findByUsername('wouter')->getDisplayName()
57			);
58			$this->assertNotEquals(
59			$updatingUser->getPassword(),
60			$this->userRepository->findByUsername('wouter')->getPassword()
61			);
62			}
63			}
64

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#10)

UpdateUserHandlerTest::testUpdateUserGetsHandled() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like