DeleteUserCommand::execute() - Code Metrics - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

DeleteUserCommand::execute() A
last analyzed 2018-11-26 16:44 UTC

↳ Parent: DeleteUserCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Console;

use SumoCoders\FrameworkMultiUserBundle\Command\DeleteUserHandler;
use SumoCoders\FrameworkMultiUserBundle\DataTransferObject\Interfaces\UserDataTransferObject;
use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

final class DeleteUserCommand extends Command
{
    /** @var UserRepository */
    private $userRepository;

    /** @var DeleteUserHandler */
    private $handler;

    public function __construct(UserRepository $userRepository, DeleteUserHandler $handler)
    {
        parent::__construct();
        $this->userRepository = $userRepository;
        $this->handler = $handler;
    }

    protected function configure(): void
    {
        $this
            ->setName('sumocoders:multiuser:delete')
            ->setDescription('Delete a user entity')
            ->addArgument(
                'username',
                InputArgument::REQUIRED,
                'The username of the user'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $username = $input->getArgument('username');
        $user = $this->userRepository->findByUsername($username);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (!$user) {
            $output->writeln('<error>'.$username.' doesn\'t exists');

            return;
        }

        $baseUserTransferObject = UserDataTransferObject::fromUser($user);

        $this->handler->handle($baseUserTransferObject);

        $output->writeln($username . ' has been deleted');
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Console;
4
5			use SumoCoders\FrameworkMultiUserBundle\Command\DeleteUserHandler;
6			use SumoCoders\FrameworkMultiUserBundle\DataTransferObject\Interfaces\UserDataTransferObject;
7			use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
8			use Symfony\Component\Console\Command\Command;
9			use Symfony\Component\Console\Input\InputArgument;
10			use Symfony\Component\Console\Input\InputInterface;
11			use Symfony\Component\Console\Output\OutputInterface;
12
13			final class DeleteUserCommand extends Command
14			{
15			/** @var UserRepository */
16			private $userRepository;
17
18			/** @var DeleteUserHandler */
19			private $handler;
20
21			public function __construct(UserRepository $userRepository, DeleteUserHandler $handler)
22			{
23			parent::__construct();
24			$this->userRepository = $userRepository;
25			$this->handler = $handler;
26			}
27
28			protected function configure(): void
29			{
30			$this
31			->setName('sumocoders:multiuser:delete')
32			->setDescription('Delete a user entity')
33			->addArgument(
34			'username',
35			InputArgument::REQUIRED,
36			'The username of the user'
37			)
38			;
39			}
40
41			protected function execute(InputInterface $input, OutputInterface $output): void
42			{
43			$username = $input->getArgument('username');
44			$user = $this->userRepository->findByUsername($username);
			0 ignored issues – show Bug introduced 2018-11-13 08:23 UTC by Report Bug Copy Issue Report It seems like `$username` defined by `$input->getArgument('username')` on line `43` can also be of type `array<integer,string>` or `null`; however, `SumoCoders\FrameworkMult...itory::findByUsername()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
45
46			if (!$user) {
47			$output->writeln('<error>'.$username.' doesn\'t exists');
48
49			return;
50			}
51
52			$baseUserTransferObject = UserDataTransferObject::fromUser($user);
53
54			$this->handler->handle($baseUserTransferObject);
55
56			$output->writeln($username . ' has been deleted');
57			}
58			}
59

sumocoders / FrameworkMultiUserBundle

DeleteUserCommand::execute() A last analyzed 2018-11-26 16:44 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DeleteUserCommand::execute() A
last analyzed 2018-11-26 16:44 UTC