SumoCoders\FrameworkUserBundle\Controller\EditController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	30	1
B	editAction()	0	16	5

<?php

namespace SumoCoders\FrameworkUserBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use SumoCoders\FrameworkCoreBundle\BreadCrumb\BreadCrumbBuilder;
use SumoCoders\FrameworkMultiUserBundle\Command\Handler;
use SumoCoders\FrameworkMultiUserBundle\Controller\UserController;
use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * @Route(service="sumo_coders.user.controller.edit_user")
 */
final class EditController extends UserController
{
    /** @var AuthorizationCheckerInterface */
    private $authorizationChecker;

    /** @var TokenStorageInterface */
    private $tokenStorage;

    public function __construct(
        AuthorizationCheckerInterface $authorizationChecker,
        TokenStorageInterface $tokenStorage,
        FormFactoryInterface $formFactory,
        Router $router,
        FlashBagInterface $flashBag,
        TranslatorInterface $translator,
        string $form,
        Handler $handler,
        UserRepository $userRepository,
        BreadCrumbBuilder $breadCrumbBuilder,
        array $breadcrumbs,
        $redirectRoute = null
    ) {
        $this->authorizationChecker = $authorizationChecker;
        $this->tokenStorage = $tokenStorage;

        parent::__construct(
            $formFactory,
            $router,
            $flashBag,
            $translator,
            $form,
            $handler,
            $userRepository,
            $breadCrumbBuilder,
            $breadcrumbs,
            $redirectRoute
        );
    }

    /**
     * @Template("SumoCodersFrameworkMultiUserBundle:User:base.html.twig")
     *
     * @param Request $request
     * @param int|null $id
     *
     * @return array|RedirectResponse
     *
     * @throws AccessDeniedHttpException if not allowed to edit user
     */
    public function editAction(Request $request, ?int $id)
    {
        if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')
            && $this->tokenStorage->getToken()->getUser()->getId() !== $id
        ) {
            throw new AccessDeniedHttpException('Access denied.');
        }

        $response = parent::baseAction($request, $id);

It seems like you call parent on a different method (baseAction() instead of editAction()). Are you sure this is correct? If so, you might want to change this to $this->baseAction().

        if ($response instanceof RedirectResponse && !$this->authorizationChecker->isGranted('ROLE_ADMIN')) {
            return RedirectResponse::create($request->getPathInfo());
        }

        return $response;
    }
}