User::change() - Code Metrics - Inspection of "User bundle roles adjustments" - sumocoders/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#243)

unknown

created 2019-01-17 09:54 UTC

User::change() A

↳ Parent: User

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	0
cp	0
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	12

<?php

namespace SumoCoders\FrameworkUserBundle\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use SumoCoders\FrameworkMultiUserBundle\DataTransferObject\Interfaces\UserDataTransferObject;
use SumoCoders\FrameworkMultiUserBundle\Entity\BaseUser;
use SumoCoders\FrameworkMultiUserBundle\Entity\UserRole;
use SumoCoders\FrameworkMultiUserBundle\Security\PasswordResetToken;

/**
 * @ORM\Entity(repositoryClass="SumoCoders\FrameworkUserBundle\Repository\UserRepository")
 * @ORM\Table()
 */
class User extends BaseUser
{
    public function __construct(
        string $plainPassword,
        string $displayName,
        string $email,
        Collection $roles,
        int $id = null,
        PasswordResetToken $token = null
    ) {
        parent::__construct($email, $plainPassword, $displayName, $email, $roles, $id, $token);
    }

    public function hasRole(string $roleName): bool
    {
        if (empty($this->roles)) {
            return false;
        }

        /** @var UserRole $role */
        foreach ($this->roles as $role) {
            if ($role->getRole() === $roleName) {
                return true;
            }
        }

        return false;
    }

    public function change(UserDataTransferObject $data): void
    {
        parent::change($data);

        if ($data instanceof UserDataTransferObject) {
            if (is_array($data->getRoles())) {
                $this->roles = new ArrayCollection($data->getRoles());
            } else {
                $this->roles = $data->getRoles();
            }
        }
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkUserBundle\Entity;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Doctrine\Common\Collections\Collection;
7			use Doctrine\ORM\Mapping as ORM;
8			use SumoCoders\FrameworkMultiUserBundle\DataTransferObject\Interfaces\UserDataTransferObject;
9			use SumoCoders\FrameworkMultiUserBundle\Entity\BaseUser;
10			use SumoCoders\FrameworkMultiUserBundle\Entity\UserRole;
11			use SumoCoders\FrameworkMultiUserBundle\Security\PasswordResetToken;
12
13			/**
14			* @ORM\Entity(repositoryClass="SumoCoders\FrameworkUserBundle\Repository\UserRepository")
15			* @ORM\Table()
16			*/
17			class User extends BaseUser
18			{
19			public function __construct(
20			string $plainPassword,
21			string $displayName,
22			string $email,
23			Collection $roles,
24			int $id = null,
25			PasswordResetToken $token = null
26			) {
27			parent::__construct($email, $plainPassword, $displayName, $email, $roles, $id, $token);
28			}
29
30			public function hasRole(string $roleName): bool
31			{
32			if (empty($this->roles)) {
33			return false;
34			}
35
36			/** @var UserRole $role */
37			foreach ($this->roles as $role) {
38			if ($role->getRole() === $roleName) {
39			return true;
40			}
41			}
42
43			return false;
44			}
45
46			public function change(UserDataTransferObject $data): void
47			{
48			parent::change($data);
49
50			if ($data instanceof UserDataTransferObject) {
51			if (is_array($data->getRoles())) {
52			$this->roles = new ArrayCollection($data->getRoles());
53			} else {
54			$this->roles = $data->getRoles();
55			}
56			}
57			}
58			}
59

sumocoders / Framework

Pull Request — master (#243)

User::change() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like