DatePickerController::indexAction() - Code Metrics - Inspection of "Merge pull request #126 from sumocoders/staging-ph..." - sumocoders/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dcf43c...59d132 )

by Tijs

created 2016-06-07 13:37 UTC

DatePickerController::indexAction() B

↳ Parent: DatePickerController

Complexity

Conditions	1
Paths	1

Size

Total Lines	198
Code Lines	154

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	155
CRAP Score	1

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	198
ccs	155
cts	155
cp	1
rs	8.2857
cc	1
eloc	154
nc	1
nop	0
crap	1

How to fix Long Method

<?php

namespace SumoCoders\FrameworkCoreBundle\Controller\Tests;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
use Symfony\Component\Form\Extension\Core\Type\DateType;
use Symfony\Component\Form\Extension\Core\Type\TimeType;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;

class DatePickerController extends Controller
{
    /**
     * @Template()
     * @Route("/datepicker")
     */
    public function indexAction()
    {
        $form = $this->createFormBuilder()
            ->add(
                'date_example1',
                DateType::class,
                array(
                    'widget' => 'choice',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example2',
                DateType::class,
                array(
                    'widget' => 'text',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example3',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'date_example4',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'date_example5',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'date_type' => 'normal',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example6',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'date_type' => 'start',
                    'minimum_date' => new \DateTime('last monday'),
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example7',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'date_type' => 'until',
                    'maximum_date' => new \DateTime('next friday'),
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example8',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'date_type' => 'range',
                    'minimum_date' => new \DateTime('last monday'),
                    'maximum_date' => new \DateTime('next friday'),
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'date_example9',
                DateType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'required' => false,
                )
            )
            ->add(
                'datetime_example1',
                DateTimeType::class,
                array(
                    'widget' => 'choice',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'datetime_example2',
                DateTimeType::class,
                array(
                    'widget' => 'text',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'datetime_example3',
                DateTimeType::class,
                array(
                    'widget' => 'single_text',
                    'required' => false,
                    'data' => new \DateTime(),
                )
            )
            ->add(
                'time_example1',
                TimeType::class,
                array(
                    'widget' => 'choice',
                    'required' => false,
                )
            )
            ->add(
                'time_example2',
                TimeType::class,
                array(
                    'widget' => 'text',
                    'required' => false,
                )
            )
            ->add(
                'time_example3',
                TimeType::class,
                array(
                    'widget' => 'single_text',
                    'required' => false,
                )
            )
            ->add(
                'birthday_example1',
                BirthdayType::class,
                array(
                    'widget' => 'choice',
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'birthday_example2',
                BirthdayType::class,
                array(
                    'widget' => 'text',
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'birthday_example3',
                BirthdayType::class,
                array(
                    'widget' => 'single_text',
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'birthday_example4',
                BirthdayType::class,
                array(
                    'widget' => 'single_text',
                    'datepicker' => true,
                    'required' => false,
                    'data' => new \DateTime('20 june 1985 13:37:00'),
                )
            )
            ->add(
                'save',
                SubmitType::class,
                array(
                    'label' => 'Ok',
                )
            )
            ->getForm();

        return array(
            'form' => $form->createView()
        );
    }
}


1		<?php
2
3		namespace SumoCoders\FrameworkCoreBundle\Controller\Tests;
4
5		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
8		use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
9		use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
10		use Symfony\Component\Form\Extension\Core\Type\DateType;
11		use Symfony\Component\Form\Extension\Core\Type\TimeType;
12		use Symfony\Component\Form\Extension\Core\Type\SubmitType;
13
14		class DatePickerController extends Controller
15		{
16		/**
17		* @Template()
18		* @Route("/datepicker")
19		*/
20	9	public function indexAction()
21		{
22	9	$form = $this->createFormBuilder()
23	9	->add(
24	9	'date_example1',
25	9	DateType::class,
26		array(
27	9	'widget' => 'choice',
28	9	'required' => false,
29	9	'data' => new \DateTime(),
30		)
31	9	)
32	9	->add(
33	9	'date_example2',
34	9	DateType::class,
35		array(
36	9	'widget' => 'text',
37	9	'required' => false,
38	9	'data' => new \DateTime(),
39		)
40	9	)
41	9	->add(
42	9	'date_example3',
43	9	DateType::class,
44		array(
45	9	'widget' => 'single_text',
46	9	'required' => false,
47	9	'data' => new \DateTime('20 june 1985 13:37:00'),
48		)
49	9	)
50	9	->add(
51	9	'date_example4',
52	9	DateType::class,
53		array(
54	9	'widget' => 'single_text',
55	9	'datepicker' => true,
56	9	'required' => false,
57	9	'data' => new \DateTime('20 june 1985 13:37:00'),
58		)
59	9	)
60	9	->add(
61	9	'date_example5',
62	9	DateType::class,
63		array(
64	9	'widget' => 'single_text',
65	9	'datepicker' => true,
66	9	'date_type' => 'normal',
67	9	'required' => false,
68	9	'data' => new \DateTime(),
69		)
70	9	)
71	9	->add(
72	9	'date_example6',
73	9	DateType::class,
74		array(
75	9	'widget' => 'single_text',
76	9	'datepicker' => true,
77	9	'date_type' => 'start',
78	9	'minimum_date' => new \DateTime('last monday'),
79	9	'required' => false,
80	9	'data' => new \DateTime(),
81		)
82	9	)
83	9	->add(
84	9	'date_example7',
85	9	DateType::class,
86		array(
87	9	'widget' => 'single_text',
88	9	'datepicker' => true,
89	9	'date_type' => 'until',
90	9	'maximum_date' => new \DateTime('next friday'),
91	9	'required' => false,
92	9	'data' => new \DateTime(),
93		)
94	9	)
95	9	->add(
96	9	'date_example8',
97	9	DateType::class,
98		array(
99	9	'widget' => 'single_text',
100	9	'datepicker' => true,
101	9	'date_type' => 'range',
102	9	'minimum_date' => new \DateTime('last monday'),
103	9	'maximum_date' => new \DateTime('next friday'),
104	9	'required' => false,
105	9	'data' => new \DateTime(),
106		)
107	9	)
108	9	->add(
109	9	'date_example9',
110	9	DateType::class,
111		array(
112	9	'widget' => 'single_text',
113	9	'datepicker' => true,
114	9	'required' => false,
115		)
116	9	)
117	9	->add(
118	9	'datetime_example1',
119	9	DateTimeType::class,
120		array(
121	9	'widget' => 'choice',
122	9	'required' => false,
123	9	'data' => new \DateTime(),
124		)
125	9	)
126	9	->add(
127	9	'datetime_example2',
128	9	DateTimeType::class,
129		array(
130	9	'widget' => 'text',
131	9	'required' => false,
132	9	'data' => new \DateTime(),
133		)
134	9	)
135	9	->add(
136	9	'datetime_example3',
137	9	DateTimeType::class,
138		array(
139	9	'widget' => 'single_text',
140	9	'required' => false,
141	9	'data' => new \DateTime(),
142		)
143	9	)
144	9	->add(
145	9	'time_example1',
146	9	TimeType::class,
147		array(
148	9	'widget' => 'choice',
149	9	'required' => false,
150		)
151	9	)
152	9	->add(
153	9	'time_example2',
154	9	TimeType::class,
155		array(
156	9	'widget' => 'text',
157	9	'required' => false,
158		)
159	9	)
160	9	->add(
161	9	'time_example3',
162	9	TimeType::class,
163		array(
164	9	'widget' => 'single_text',
165	9	'required' => false,
166		)
167	9	)
168	9	->add(
169	9	'birthday_example1',
170	9	BirthdayType::class,
171		array(
172	9	'widget' => 'choice',
173	9	'required' => false,
174	9	'data' => new \DateTime('20 june 1985 13:37:00'),
175		)
176	9	)
177	9	->add(
178	9	'birthday_example2',
179	9	BirthdayType::class,
180		array(
181	9	'widget' => 'text',
182	9	'required' => false,
183	9	'data' => new \DateTime('20 june 1985 13:37:00'),
184		)
185	9	)
186	9	->add(
187	9	'birthday_example3',
188	9	BirthdayType::class,
189		array(
190	9	'widget' => 'single_text',
191	9	'required' => false,
192	9	'data' => new \DateTime('20 june 1985 13:37:00'),
193		)
194	9	)
195	9	->add(
196	9	'birthday_example4',
197	9	BirthdayType::class,
198		array(
199	9	'widget' => 'single_text',
200	9	'datepicker' => true,
201	9	'required' => false,
202	9	'data' => new \DateTime('20 june 1985 13:37:00'),
203		)
204	9	)
205	9	->add(
206	9	'save',
207	9	SubmitType::class,
208		array(
209	9	'label' => 'Ok',
210		)
211	9	)
212	9	->getForm();
213
214		return array(
215	9	'form' => $form->createView()
216	9	);
217	1	}
218		}
219

sumocoders / Framework

Push — master ( dcf43c...59d132 )

DatePickerController::indexAction() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like