EditController::__construct() - Code Metrics - Inspection of "Merge pull request #202 from jonasdekeukelaere/bas..." - sumocoders/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62a450...2faef5 )

unknown

created 2017-10-23 10:07 UTC

EditController::__construct() B

↳ Parent: EditController

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	22
nc	1
nop	10

How to fix Many Parameters

<?php

namespace SumoCoders\FrameworkUserBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use SumoCoders\FrameworkMultiUserBundle\Command\Handler;
use SumoCoders\FrameworkMultiUserBundle\Controller\UserController;
use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * @Route(service="sumo_coders.user.controller.edit_user")
 */
final class EditController extends UserController
{
    /** @var AuthorizationCheckerInterface */
    private $authorizationChecker;

    /** @var TokenStorageInterface */
    private $tokenStorage;

    public function __construct(
        AuthorizationCheckerInterface $authorizationChecker,
        TokenStorageInterface $tokenStorage,
        FormFactoryInterface $formFactory,
        Router $router,
        FlashBagInterface $flashBag,
        TranslatorInterface $translator,
        string $form,
        Handler $handler,
        UserRepository $userRepository,
        $redirectRoute = null
    ) {
        $this->authorizationChecker = $authorizationChecker;
        $this->tokenStorage = $tokenStorage;

        parent::__construct(
            $formFactory,
            $router,
            $flashBag,
            $translator,
            $form,
            $handler,
            $userRepository,
            $redirectRoute
        );
    }

    /**
     * @Template("SumoCodersFrameworkMultiUserBundle:User:base.html.twig")
     *
     * @param Request $request
     * @param int|null $id
     *
     * @return array
     *
     * @throws AccessDeniedHttpException if not allowed to edit user
     */
    public function editAction(Request $request, ?int $id): array
    {
        if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')
            && $this->tokenStorage->getToken()->getUser()->getId() !== $id
        ) {
            throw new AccessDeniedHttpException('Access denied.');
        }

        return parent::baseAction($request, $id);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkUserBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
7			use SumoCoders\FrameworkMultiUserBundle\Command\Handler;
8			use SumoCoders\FrameworkMultiUserBundle\Controller\UserController;
9			use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
10			use Symfony\Bundle\FrameworkBundle\Routing\Router;
11			use Symfony\Component\Form\FormFactoryInterface;
12			use Symfony\Component\HttpFoundation\Request;
13			use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
14			use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
15			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
16			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
17			use Symfony\Component\Translation\TranslatorInterface;
18
19			/**
20			* @Route(service="sumo_coders.user.controller.edit_user")
21			*/
22			final class EditController extends UserController
23			{
24			/** @var AuthorizationCheckerInterface */
25			private $authorizationChecker;
26
27			/** @var TokenStorageInterface */
28			private $tokenStorage;
29
30			public function __construct(
31			AuthorizationCheckerInterface $authorizationChecker,
32			TokenStorageInterface $tokenStorage,
33			FormFactoryInterface $formFactory,
34			Router $router,
35			FlashBagInterface $flashBag,
36			TranslatorInterface $translator,
37			string $form,
38			Handler $handler,
39			UserRepository $userRepository,
40			$redirectRoute = null
41			) {
42			$this->authorizationChecker = $authorizationChecker;
43			$this->tokenStorage = $tokenStorage;
44
45			parent::__construct(
46			$formFactory,
47			$router,
48			$flashBag,
49			$translator,
50			$form,
51			$handler,
52			$userRepository,
53			$redirectRoute
54			);
55			}
56
57			/**
58			* @Template("SumoCodersFrameworkMultiUserBundle:User:base.html.twig")
59			*
60			* @param Request $request
61			* @param int\|null $id
62			*
63			* @return array
64			*
65			* @throws AccessDeniedHttpException if not allowed to edit user
66			*/
67			public function editAction(Request $request, ?int $id): array
68			{
69			if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')
70			&& $this->tokenStorage->getToken()->getUser()->getId() !== $id
71			) {
72			throw new AccessDeniedHttpException('Access denied.');
73			}
74
75			return parent::baseAction($request, $id);
			0 ignored issues – show Comprehensibility Bug introduced 2017-10-19 12:04 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`baseAction()` instead of `editAction()`). Are you sure this is correct? If so, you might want to change this to `$this->baseAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
76			}
77			}
78

sumocoders / Framework

Push — master ( 62a450...2faef5 )

EditController::__construct() B

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like