EditController::__construct() - Code Metrics - Inspection of "Normal users aren't allowed to go to the overview" - sumocoders/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — carakas-patch-2 ( a68830 )

by jelmer

created 2018-03-13 17:09 UTC

EditController::__construct() B

↳ Parent: EditController

Complexity

Conditions	1
Paths	1

Size

Total Lines	30
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	30
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	26
nc	1
nop	12

How to fix Many Parameters

<?php

namespace SumoCoders\FrameworkUserBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use SumoCoders\FrameworkCoreBundle\BreadCrumb\BreadCrumbBuilder;
use SumoCoders\FrameworkMultiUserBundle\Command\Handler;
use SumoCoders\FrameworkMultiUserBundle\Controller\UserController;
use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * @Route(service="sumo_coders.user.controller.edit_user")
 */
final class EditController extends UserController
{
    /** @var AuthorizationCheckerInterface */
    private $authorizationChecker;

    /** @var TokenStorageInterface */
    private $tokenStorage;

    public function __construct(
        AuthorizationCheckerInterface $authorizationChecker,
        TokenStorageInterface $tokenStorage,
        FormFactoryInterface $formFactory,
        Router $router,
        FlashBagInterface $flashBag,
        TranslatorInterface $translator,
        string $form,
        Handler $handler,
        UserRepository $userRepository,
        BreadCrumbBuilder $breadCrumbBuilder,
        array $breadcrumbs,
        $redirectRoute = null
    ) {
        $this->authorizationChecker = $authorizationChecker;
        $this->tokenStorage = $tokenStorage;

        parent::__construct(
            $formFactory,
            $router,
            $flashBag,
            $translator,
            $form,
            $handler,
            $userRepository,
            $breadCrumbBuilder,
            $breadcrumbs,
            $redirectRoute
        );
    }

    /**
     * @Template("SumoCodersFrameworkMultiUserBundle:User:base.html.twig")
     *
     * @param Request $request
     * @param int|null $id
     *
     * @return array|RedirectResponse
     *
     * @throws AccessDeniedHttpException if not allowed to edit user
     */
    public function editAction(Request $request, ?int $id)
    {
        if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')
            && $this->tokenStorage->getToken()->getUser()->getId() !== $id
        ) {
            throw new AccessDeniedHttpException('Access denied.');
        }

        $response = parent::baseAction($request, $id);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        if ($response instanceof RedirectResponse && !$this->authorizationChecker->isGranted('ROLE_ADMIN')) {
            return RedirectResponse::create($request->getPathInfo());
        }

        return $response;
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkUserBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
7			use SumoCoders\FrameworkCoreBundle\BreadCrumb\BreadCrumbBuilder;
8			use SumoCoders\FrameworkMultiUserBundle\Command\Handler;
9			use SumoCoders\FrameworkMultiUserBundle\Controller\UserController;
10			use SumoCoders\FrameworkMultiUserBundle\User\Interfaces\UserRepository;
11			use Symfony\Bundle\FrameworkBundle\Routing\Router;
12			use Symfony\Component\Form\FormFactoryInterface;
13			use Symfony\Component\HttpFoundation\RedirectResponse;
14			use Symfony\Component\HttpFoundation\Request;
15			use Symfony\Component\HttpFoundation\Session\Flash\FlashBagInterface;
16			use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
17			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
18			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
19			use Symfony\Component\Translation\TranslatorInterface;
20
21			/**
22			* @Route(service="sumo_coders.user.controller.edit_user")
23			*/
24			final class EditController extends UserController
25			{
26			/** @var AuthorizationCheckerInterface */
27			private $authorizationChecker;
28
29			/** @var TokenStorageInterface */
30			private $tokenStorage;
31
32			public function __construct(
33			AuthorizationCheckerInterface $authorizationChecker,
34			TokenStorageInterface $tokenStorage,
35			FormFactoryInterface $formFactory,
36			Router $router,
37			FlashBagInterface $flashBag,
38			TranslatorInterface $translator,
39			string $form,
40			Handler $handler,
41			UserRepository $userRepository,
42			BreadCrumbBuilder $breadCrumbBuilder,
43			array $breadcrumbs,
44			$redirectRoute = null
45			) {
46			$this->authorizationChecker = $authorizationChecker;
47			$this->tokenStorage = $tokenStorage;
48
49			parent::__construct(
50			$formFactory,
51			$router,
52			$flashBag,
53			$translator,
54			$form,
55			$handler,
56			$userRepository,
57			$breadCrumbBuilder,
58			$breadcrumbs,
59			$redirectRoute
60			);
61			}
62
63			/**
64			* @Template("SumoCodersFrameworkMultiUserBundle:User:base.html.twig")
65			*
66			* @param Request $request
67			* @param int\|null $id
68			*
69			* @return array\|RedirectResponse
70			*
71			* @throws AccessDeniedHttpException if not allowed to edit user
72			*/
73			public function editAction(Request $request, ?int $id)
74			{
75			if (!$this->authorizationChecker->isGranted('ROLE_ADMIN')
76			&& $this->tokenStorage->getToken()->getUser()->getId() !== $id
77			) {
78			throw new AccessDeniedHttpException('Access denied.');
79			}
80
81			$response = parent::baseAction($request, $id);
			0 ignored issues – show Comprehensibility Bug introduced 2018-03-13 17:16 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`baseAction()` instead of `editAction()`). Are you sure this is correct? If so, you might want to change this to `$this->baseAction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
82
83			if ($response instanceof RedirectResponse && !$this->authorizationChecker->isGranted('ROLE_ADMIN')) {
84			return RedirectResponse::create($request->getPathInfo());
85			}
86
87			return $response;
88			}
89			}
90

sumocoders / Framework

Push — carakas-patch-2 ( a68830 )

EditController::__construct() B

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like