Issues in ActivityLogController.php (master) - Issues in master - sulu/SuluActivityLogBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/ActivityLogController.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Sulu.
 *
 * (c) MASSIVE ART WebServices GmbH
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Sulu\Bundle\ActivityLogBundle\Controller;

use FOS\RestBundle\Controller\Annotations\Get;
use FOS\RestBundle\Controller\FOSRestController;
use FOS\RestBundle\Routing\ClassResourceInterface;
use Sulu\Component\ActivityLog\ActivityLogger;
use Sulu\Component\Rest\Exception\EntityNotFoundException;
use Sulu\Component\Rest\ListBuilder\FieldDescriptor;
use Sulu\Component\Rest\ListBuilder\ListRepresentation;
use Symfony\Component\HttpFoundation\Request;

/**
 * Makes activity logs available through a REST API.
 */
class ActivityLogController extends FOSRestController implements ClassResourceInterface
{
    /**
     * Returns all fields that can be used by list.
     *
     * @Get("activity-log/fields")
     *
     * @param Request $request
     *
     * @return mixed
     */
    public function getFieldsAction(Request $request)

    {
        // default contacts list
        return $this->handleView(
            $this->view(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                array_values(
                    $this->getFieldDescriptors()
                ),
                200
            )
        );
    }

    /**
     * Shows all activity-log-items.
     *
     * @param Request $request
     *
     * @Get("activity-log")
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function cgetAction(Request $request)
    {
        $list = $this->getActivityLogs($request);

        $view = $this->view($list, 200);

        return $this->handleView($view);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Create field-descriptor array.
     *
     * @return FieldDescriptor[]
     */
    protected function getFieldDescriptors()
    {
        return [
            'uuid' => new FieldDescriptor('uuid', 'public.id', true, false),
            'type' => new FieldDescriptor('type', 'sulu_activity_log.type', false, true),
            'title' => new FieldDescriptor('title', 'public.title', false, true),
            'message' => new FieldDescriptor('message', 'sulu_activity_log.message', false, true),
            'created' => new FieldDescriptor('created', 'public.created', false, true, 'datetime'),
        ];
    }

    /**
     * returns view of files.
     *
     * @param Request $request
     *
     * @throws EntityNotFoundException
     *
     * @return ListRepresentation
     */
    protected function getActivityLogs(Request $request)
    {
        $restHelper = $this->get('sulu_core.list_rest_helper');

        /** @var ActivityLogger $activityLogger */
        $activityLogger = $this->get('sulu_activity_log.activity_logger');

        $page = (int) $restHelper->getPage();
        $limit = (int) $restHelper->getLimit();
        $sortColumn = $restHelper->getSortColumn();
        $sortOrder = $restHelper->getSortOrder();
        $searchPattern = $restHelper->getSearchPattern();
        $searchFields = $restHelper->getSearchFields();

        $list = $activityLogger->findAllWithSearch(
            $searchPattern,
            $searchFields,
            $page,
            $limit,
            $sortColumn,
            $sortOrder
        );

        $total = $activityLogger->getCountForAllWithSearch($searchPattern, $searchFields);

        $list = array_values($list);

        $list = new ListRepresentation(
            $list,
            'activity-log-items',
            'get_activity_logs',
            $request->query->all(),
            $page,
            $limit,
            $total
        );

        return $list;
    }
}


1		<?php
2
3		/*
4		* This file is part of Sulu.
5		*
6		* (c) MASSIVE ART WebServices GmbH
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Sulu\Bundle\ActivityLogBundle\Controller;
13
14		use FOS\RestBundle\Controller\Annotations\Get;
15		use FOS\RestBundle\Controller\FOSRestController;
16		use FOS\RestBundle\Routing\ClassResourceInterface;
17		use Sulu\Component\ActivityLog\ActivityLogger;
18		use Sulu\Component\Rest\Exception\EntityNotFoundException;
19		use Sulu\Component\Rest\ListBuilder\FieldDescriptor;
20		use Sulu\Component\Rest\ListBuilder\ListRepresentation;
21		use Symfony\Component\HttpFoundation\Request;
22
23		/**
24		* Makes activity logs available through a REST API.
25		*/
26		class ActivityLogController extends FOSRestController implements ClassResourceInterface
27		{
28		/**
29		* Returns all fields that can be used by list.
30		*
31		* @Get("activity-log/fields")
32		*
33		* @param Request $request
34		*
35		* @return mixed
36		*/
37		public function getFieldsAction(Request $request)
		0 ignored issues – show Unused Code introduced 2017-04-20 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38		{
39		// default contacts list
40		return $this->handleView(
41		$this->view(
		0 ignored issues – show Documentation introduced 2017-04-20 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->view(array_values...eldDescriptors()), 200)` is of type `this<Sulu\Bundle\Activit...\ActivityLogController>`, but the function expects a `object<FOS\RestBundle\View\View>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42		array_values(
43		$this->getFieldDescriptors()
44		),
45		200
46		)
47		);
48		}
49
50		/**
51		* Shows all activity-log-items.
52		*
53		* @param Request $request
54		*
55		* @Get("activity-log")
56		*
57		* @return \Symfony\Component\HttpFoundation\Response
58		*/
59	5	public function cgetAction(Request $request)
60		{
61	5	$list = $this->getActivityLogs($request);
62
63	5	$view = $this->view($list, 200);
64
65	5	return $this->handleView($view);
		0 ignored issues – show Documentation introduced 2017-04-20 10:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$view` is of type `this<Sulu\Bundle\Activit...\ActivityLogController>`, but the function expects a `object<FOS\RestBundle\View\View>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
66		}
67
68		/**
69		* Create field-descriptor array.
70		*
71		* @return FieldDescriptor[]
72		*/
73		protected function getFieldDescriptors()
74		{
75		return [
76		'uuid' => new FieldDescriptor('uuid', 'public.id', true, false),
77		'type' => new FieldDescriptor('type', 'sulu_activity_log.type', false, true),
78		'title' => new FieldDescriptor('title', 'public.title', false, true),
79		'message' => new FieldDescriptor('message', 'sulu_activity_log.message', false, true),
80		'created' => new FieldDescriptor('created', 'public.created', false, true, 'datetime'),
81		];
82		}
83
84		/**
85		* returns view of files.
86		*
87		* @param Request $request
88		*
89		* @throws EntityNotFoundException
90		*
91		* @return ListRepresentation
92		*/
93	5	protected function getActivityLogs(Request $request)
94		{
95	5	$restHelper = $this->get('sulu_core.list_rest_helper');
96
97		/** @var ActivityLogger $activityLogger */
98	5	$activityLogger = $this->get('sulu_activity_log.activity_logger');
99
100	5	$page = (int) $restHelper->getPage();
101	5	$limit = (int) $restHelper->getLimit();
102	5	$sortColumn = $restHelper->getSortColumn();
103	5	$sortOrder = $restHelper->getSortOrder();
104	5	$searchPattern = $restHelper->getSearchPattern();
105	5	$searchFields = $restHelper->getSearchFields();
106
107	5	$list = $activityLogger->findAllWithSearch(
108		$searchPattern,
109		$searchFields,
110		$page,
111		$limit,
112		$sortColumn,
113	5	$sortOrder
114		);
115
116	5	$total = $activityLogger->getCountForAllWithSearch($searchPattern, $searchFields);
117
118	5	$list = array_values($list);
119
120	5	$list = new ListRepresentation(
121		$list,
122	5	'activity-log-items',
123	5	'get_activity_logs',
124	5	$request->query->all(),
125		$page,
126		$limit,
127	5	$total
128		);
129
130	5	return $list;
131		}
132		}
133

sulu / SuluActivityLogBundle

Issues (6)

Security Analysis not enabled

Controller/ActivityLogController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like