Issues in PropertyEncoder.php (master) - Issues in master - sulu-io/sulu-document-manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (47)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/PropertyEncoder.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Sulu.
 *
 * (c) MASSIVE ART WebServices GmbH
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Sulu\Component\DocumentManager;

use Sulu\Component\DocumentManager\Exception\InvalidLocaleException;

/**
 * Class responsible for encoding properties to PHPCR nodes.
 */
class PropertyEncoder
{
    /**
     * @var NamespaceRegistry
     */
    private $namespaceRegistry;

    /**
     * @param NamespaceRegistry $namespaceRegistry
     */
    public function __construct(NamespaceRegistry $namespaceRegistry)
    {
        $this->namespaceRegistry = $namespaceRegistry;
    }

    public function encode($encoding, $name, $locale)
    {
        switch ($encoding) {
            case 'system_localized':
                return $this->localizedSystemName($name, $locale);
            case 'system':
                return $this->systemName($name);
            case 'content_localized':
                return $this->localizedContentName($name, $locale);
            case 'content':
                return $this->contentName($name);
            default:
                throw new \InvalidArgumentException(sprintf(
                    'Invalid encoding "%s"', $encoding
                ));
        }
    }

    /**
     * @param string $name
     * @param string $locale
     *
     * @return string
     */
    public function localizedSystemName($name, $locale)
    {
        if ($locale === null) {
            throw new InvalidLocaleException($locale);
        }

        return $this->formatLocalizedName('system_localized', $name, $locale);
    }

    /**
     * @param string $name
     *
     * @return string
     */
    public function systemName($name)
    {
        return $this->formatName('system', $name);
    }

    /**
     * @param string $name
     * @param string $locale
     *
     * @return string
     */
    public function localizedContentName($name, $locale)
    {
        if ($locale === null) {
            throw new InvalidLocaleException($locale);
        }

        return $this->formatLocalizedName('content_localized', $name, $locale);
    }

    /**
     * @param string $name
     *
     * @return string
     */
    public function contentName($name)
    {
        return $this->formatName('content', $name);
    }

    private function formatName($role, $name)

    {
        $prefix = $this->namespaceRegistry->getPrefix($role);

        if (!$prefix) {
            return $name;
        }

        return sprintf(
            '%s:%s',
            $prefix,
            $name
        );
    }

    private function formatLocalizedName($role, $name, $locale)

    {
        $prefix = $this->namespaceRegistry->getPrefix($role);

        if (!$prefix) {
            return sprintf('%s-%s', $locale, $name);
        }

        return sprintf(
            '%s:%s-%s',
            $prefix,
            $locale,
            $name
        );
    }
}


1		<?php
2
3		/*
4		* This file is part of Sulu.
5		*
6		* (c) MASSIVE ART WebServices GmbH
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Sulu\Component\DocumentManager;
13
14		use Sulu\Component\DocumentManager\Exception\InvalidLocaleException;
15
16		/**
17		* Class responsible for encoding properties to PHPCR nodes.
18		*/
19		class PropertyEncoder
20		{
21		/**
22		* @var NamespaceRegistry
23		*/
24		private $namespaceRegistry;
25
26		/**
27		* @param NamespaceRegistry $namespaceRegistry
28		*/
29		public function __construct(NamespaceRegistry $namespaceRegistry)
30		{
31		$this->namespaceRegistry = $namespaceRegistry;
32		}
33
34		public function encode($encoding, $name, $locale)
35		{
36		switch ($encoding) {
37		case 'system_localized':
38		return $this->localizedSystemName($name, $locale);
39		case 'system':
40		return $this->systemName($name);
41		case 'content_localized':
42		return $this->localizedContentName($name, $locale);
43		case 'content':
44		return $this->contentName($name);
45		default:
46		throw new \InvalidArgumentException(sprintf(
47		'Invalid encoding "%s"', $encoding
48		));
49		}
50		}
51
52		/**
53		* @param string $name
54		* @param string $locale
55		*
56		* @return string
57		*/
58		public function localizedSystemName($name, $locale)
59		{
60		if ($locale === null) {
61		throw new InvalidLocaleException($locale);
62		}
63
64		return $this->formatLocalizedName('system_localized', $name, $locale);
65		}
66
67		/**
68		* @param string $name
69		*
70		* @return string
71		*/
72		public function systemName($name)
73		{
74		return $this->formatName('system', $name);
75		}
76
77		/**
78		* @param string $name
79		* @param string $locale
80		*
81		* @return string
82		*/
83		public function localizedContentName($name, $locale)
84		{
85		if ($locale === null) {
86		throw new InvalidLocaleException($locale);
87		}
88
89		return $this->formatLocalizedName('content_localized', $name, $locale);
90		}
91
92		/**
93		* @param string $name
94		*
95		* @return string
96		*/
97		public function contentName($name)
98		{
99		return $this->formatName('content', $name);
100		}
101
102	View Code Duplication	private function formatName($role, $name)
		0 ignored issues – show Duplication introduced 2015-12-01 15:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		$prefix = $this->namespaceRegistry->getPrefix($role);
105
106		if (!$prefix) {
107		return $name;
108		}
109
110		return sprintf(
111		'%s:%s',
112		$prefix,
113		$name
114		);
115		}
116
117	View Code Duplication	private function formatLocalizedName($role, $name, $locale)
		0 ignored issues – show Duplication introduced 2015-12-01 15:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		{
119		$prefix = $this->namespaceRegistry->getPrefix($role);
120
121		if (!$prefix) {
122		return sprintf('%s-%s', $locale, $name);
123		}
124
125		return sprintf(
126		'%s:%s-%s',
127		$prefix,
128		$locale,
129		$name
130		);
131		}
132		}
133

sulu-io / sulu-document-manager

Issues (47)

Security Analysis no request data

lib/PropertyEncoder.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like