SugaredRim\PHP\CodeSniffer\SugaredRimConfigAwareTrait

Complexity

Total Complexity

21

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	sugaredRimSetFinderByConfig()	0	12	2
A	sugaredRimGetConfig()	0	16	3
A	processLongArgument()	0	10	2
B	setCommandLineValues()	0	18	6
B	sugaredRimProcessConfig()	0	16	6
A	sugaredRimSetConfigData()	0	8	2

<?php

namespace SugaredRim\PHP\CodeSniffer;

use Schnittstabil\ComposerExtra\ComposerExtra;
use Schnittstabil\FinderByConfig\FinderByConfig;

trait SugaredRimConfigAwareTrait
{
    protected $sugaredRimNamespace = 'sugared-rim/php_codesniffer';
    protected $sugaredRimfinderByConfig;
    protected $sugaredRimDefaultConfig;
    protected $sugaredRimConfig;

    protected function sugaredRimSetFinderByConfig(callable $finderByConfig = null)
    {
        if ($finderByConfig === null) {
            $finderByConfig = new FinderByConfig();
        }
        $this->sugaredRimfinderByConfig = $finderByConfig;

        $this->sugaredRimDefaultConfig = new \stdClass();
        $this->sugaredRimDefaultConfig->presets = [
            'SugaredRim\\PHP\\CodeSniffer\\DefaultPreset::get',
        ];
    }

    protected function sugaredRimGetConfig($path = null, $default = null)
    {
        if ($this->sugaredRimConfig === null) {
            $this->sugaredRimConfig = new ComposerExtra(
                $this->sugaredRimNamespace,
                $this->sugaredRimDefaultConfig,
                'presets'
            );
        }

        if ($path === null) {
            $path = array();
        }

        return $this->sugaredRimConfig->get($path, $default);
    }

    public function processLongArgument($arg, $pos)
    {
        if (substr($arg, 0, 10) === 'namespace=') {
            $this->sugaredRimNamespace = substr($arg, 10);

            return;
        }

        parent::processLongArgument($arg, $pos);
    }

    public function setCommandLineValues($args)
    {
        parent::setCommandLineValues($args);

        if (isset($this->values) && !empty($this->values['files'])) {

The property values does not exist. Did you maybe forget to declare it?

            // v2.*
            return;
        }elseif (isset($this->files) && !empty($this->files)) {

The property files does not exist. Did you maybe forget to declare it?

            // v3.*
            return;
        }

        $files = $this->sugaredRimGetConfig('files', []);

        foreach (call_user_func($this->sugaredRimfinderByConfig, $files) as $file) {
            $this->processUnknownArgument($file->getPathname(), -1);

It seems like processUnknownArgument() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }

    /**
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    protected function sugaredRimProcessConfig()
    {
        foreach ($this->sugaredRimGetConfig() as $key => $value) {
            switch ($key) {
                case 'presets':
                case 'files':
                    continue 2;
                case 'default_standard':
                    if (is_array($value)) {
                        $value = implode(',', $value);
                    }
            }

            $this->sugaredRimSetConfigData($key, $value, true);
        }
    }

    protected function sugaredRimSetConfigData($key, $value, $temp = false)

The parameter $temp is not used and could be removed.

    {
        if (method_exists($this, 'setConfigData')) {
            $this->setConfigData($key, $value, true);

The method setConfigData() does not exist on SugaredRim\PHP\CodeSniffer\SugaredRimConfigAwareTrait. Did you maybe mean sugaredRimSetConfigData()?

        } else {
            \PHP_CodeSniffer::setConfigData($key, $value, true);
        }
    }
}