Config::setCommandLineValues() - Code Metrics - Inspection of "add support for PHP_CodeSniffer v3" - sugared-rim/php_codesniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 590f4c...1ff8f1 )

by Michael

created 2018-03-27 21:13 UTC

Config::setCommandLineValues() A

↳ Parent: Config

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1

<?php

namespace SugaredRim\PHP\CodeSniffer;

use Schnittstabil\ComposerExtra\ComposerExtra;
use Schnittstabil\FinderByConfig\FinderByConfig;

class Config extends \PHP_CodeSniffer\Config
{
    protected $sugaredRimNamespace = 'sugared-rim/php_codesniffer';
    protected $sugaredRimfinderByConfig;
    protected $sugaredRimDefaultConfig;
    protected $sugaredRimConfig;

    public function __construct(array $cliArgs = [], $dieOnUnknownArg = true, callable $finderByConfig = null)
    {
        if ($finderByConfig === null) {
            $finderByConfig = new FinderByConfig();
        }
        $this->sugaredRimfinderByConfig = $finderByConfig;

        $this->sugaredRimDefaultConfig = new \stdClass();
        $this->sugaredRimDefaultConfig->presets = [
            'SugaredRim\\PHP\\CodeSniffer\\DefaultPreset::get',
        ];

        parent::__construct($cliArgs, $dieOnUnknownArg);
    }

    protected function sugaredRimGetConfig($path = null, $default = null)

    {
        if ($this->sugaredRimConfig === null) {
            $this->sugaredRimConfig = new ComposerExtra(
                $this->sugaredRimNamespace,
                $this->sugaredRimDefaultConfig,
                'presets'
            );
        }

        if ($path === null) {
            $path = array();
        }

        return $this->sugaredRimConfig->get($path, $default);
    }

    public function processLongArgument($arg, $pos)
    {
        if (substr($arg, 0, 10) === 'namespace=') {
            $this->sugaredRimNamespace = substr($arg, 10);

            return;
        }

        parent::processLongArgument($arg, $pos);
    }

    public function setCommandLineValues($args)

    {
        parent::setCommandLineValues($args);

        if (!empty($this->files)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return;
        }

        $files = $this->sugaredRimGetConfig('files', []);

        foreach (call_user_func($this->sugaredRimfinderByConfig, $files) as $file) {
            $this->processUnknownArgument($file->getPathname(), -1);
        }
    }

    /**
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    protected function sugaredRimProcessConfig()

    {
        foreach ($this->sugaredRimGetConfig() as $key => $value) {
            switch ($key) {
                case 'presets':
                case 'files':
                    continue 2;
                case 'default_standard':
                    if (is_array($value)) {
                        $value = implode(',', $value);
                    }
            }

            $this->setConfigData($key, $value, true);
        }
    }
}


1		<?php
2
3		namespace SugaredRim\PHP\CodeSniffer;
4
5		use Schnittstabil\ComposerExtra\ComposerExtra;
6		use Schnittstabil\FinderByConfig\FinderByConfig;
7
8		class Config extends \PHP_CodeSniffer\Config
9		{
10		protected $sugaredRimNamespace = 'sugared-rim/php_codesniffer';
11		protected $sugaredRimfinderByConfig;
12		protected $sugaredRimDefaultConfig;
13		protected $sugaredRimConfig;
14
15		public function __construct(array $cliArgs = [], $dieOnUnknownArg = true, callable $finderByConfig = null)
16		{
17		if ($finderByConfig === null) {
18		$finderByConfig = new FinderByConfig();
19		}
20		$this->sugaredRimfinderByConfig = $finderByConfig;
21
22		$this->sugaredRimDefaultConfig = new \stdClass();
23		$this->sugaredRimDefaultConfig->presets = [
24		'SugaredRim\\PHP\\CodeSniffer\\DefaultPreset::get',
25		];
26
27		parent::__construct($cliArgs, $dieOnUnknownArg);
28		}
29
30	View Code Duplication	protected function sugaredRimGetConfig($path = null, $default = null)
		0 ignored issues – show Duplication introduced 2018-03-27 21:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		if ($this->sugaredRimConfig === null) {
33		$this->sugaredRimConfig = new ComposerExtra(
34		$this->sugaredRimNamespace,
35		$this->sugaredRimDefaultConfig,
36		'presets'
37		);
38		}
39
40		if ($path === null) {
41		$path = array();
42		}
43
44		return $this->sugaredRimConfig->get($path, $default);
45		}
46
47		public function processLongArgument($arg, $pos)
48		{
49		if (substr($arg, 0, 10) === 'namespace=') {
50		$this->sugaredRimNamespace = substr($arg, 10);
51
52		return;
53		}
54
55		parent::processLongArgument($arg, $pos);
56		}
57
58	View Code Duplication	public function setCommandLineValues($args)
		0 ignored issues – show Duplication introduced 2018-03-27 21:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		parent::setCommandLineValues($args);
61
62		if (!empty($this->files)) {
		0 ignored issues – show Documentation introduced 2018-03-27 21:19 UTC by Report Bug Copy Issue Report The property `files` does not exist on `object<SugaredRim\PHP\CodeSniffer\Config>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
63		return;
64		}
65
66		$files = $this->sugaredRimGetConfig('files', []);
67
68		foreach (call_user_func($this->sugaredRimfinderByConfig, $files) as $file) {
69		$this->processUnknownArgument($file->getPathname(), -1);
70		}
71		}
72
73		/**
74		* @SuppressWarnings(PHPMD.StaticAccess)
75		*/
76	View Code Duplication	protected function sugaredRimProcessConfig()
		0 ignored issues – show Duplication introduced 2018-03-27 21:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		foreach ($this->sugaredRimGetConfig() as $key => $value) {
79		switch ($key) {
80		case 'presets':
81		case 'files':
82		continue 2;
83		case 'default_standard':
84		if (is_array($value)) {
85		$value = implode(',', $value);
86		}
87		}
88
89		$this->setConfigData($key, $value, true);
90		}
91		}
92		}
93

sugared-rim / php_codesniffer

Push — master ( 590f4c...1ff8f1 )

Config::setCommandLineValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like