Issues in load-email-log.php - All Issues - Inspection of "Merge pull request #104 from sudar/scrutinizer-pat..." - sudar/email-log - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev/2.1.0 ( 39cfde...c5edab )

by Sudar

created 2017-09-12 17:55 UTC

load-email-log.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Load Email Log plugin.
 *
 * We need this load code in a separate file since it requires namespace
 * and using namespace in PHP 5.2 will generate a fatal error.
 *
 * @since 2.0
 */

/**
 * Load Email Log plugin.
 *
 * @since 2.0
 *
 * @param string $plugin_file Main plugin file.
 */
function load_email_log( $plugin_file ) {
	global $email_log;

	$plugin_dir = plugin_dir_path( $plugin_file );

	// setup autoloader.
	require_once 'include/EmailLogAutoloader.php';

	$loader = new \EmailLog\EmailLogAutoloader();
	$loader->add_namespace( 'EmailLog', $plugin_dir . 'include' );

	if ( file_exists( $plugin_dir . 'tests/' ) ) {
		// if tests are present, then add them.
		$loader->add_namespace( 'EmailLog', $plugin_dir . 'tests/wp-tests' );
	}

	$loader->add_file( $plugin_dir . 'include/Util/helper.php' );
	$loader->add_file( $plugin_dir . 'include/Addon/addon-helper.php' );

	$loader->register();

	$email_log = new \EmailLog\Core\EmailLog( $plugin_file, $loader, new \EmailLog\Core\DB\TableManager() );

	if ( \EmailLog\Util\is_admin_non_ajax_request() ) {
		// Loading licenser in frontend or ajax request is resulting in huge performance issues.
		$email_log->set_licenser( new \EmailLog\Addon\License\Licenser() );

		$email_log->add_loadie( new \EmailLog\Addon\DependencyEnforcer() );
		$email_log->add_loadie( new \EmailLog\Core\Request\OverridePluginAPI() );
	}

	$email_log->add_loadie( new \EmailLog\Core\EmailLogger() );
	$email_log->add_loadie( new \EmailLog\Core\UI\UILoader() );
	$email_log->add_loadie( new \EmailLog\Core\UI\Setting\EmailLogSetting() );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

	$email_log->add_loadie( new \EmailLog\Core\Request\NonceChecker() );
	$email_log->add_loadie( new \EmailLog\Core\Request\LogListAction() );
	$email_log->add_loadie( new \EmailLog\Core\Request\OverridePluginAPI() );

	// `register_activation_hook` can't be called from inside any hook.
	register_activation_hook( $plugin_file, array( $email_log->table_manager, 'on_activate' ) );

	// Ideally the plugin should be loaded in a later event like `init` or `wp_loaded`.
	// But some plugins like EDD are sending emails in `init` event itself,
	// which won't be logged if the plugin is loaded in `wp_loaded` or `init`.
	add_action( 'plugins_loaded', array( $email_log, 'load' ), 101 );
}

/**
 * Return the global instance of Email Log plugin.
 * Eventually the EmailLog class might become singleton.
 *
 * @since 2.0
 *
 * @global \EmailLog\Core\EmailLog $email_log
 * @return \EmailLog\Core\EmailLog
 */
function email_log() {
	global $email_log;

	return $email_log;
}


1			<?php
2			/**
3			* Load Email Log plugin.
4			*
5			* We need this load code in a separate file since it requires namespace
6			* and using namespace in PHP 5.2 will generate a fatal error.
7			*
8			* @since 2.0
9			*/
10
11			/**
12			* Load Email Log plugin.
13			*
14			* @since 2.0
15			*
16			* @param string $plugin_file Main plugin file.
17			*/
18			function load_email_log( $plugin_file ) {
19			global $email_log;
20
21			$plugin_dir = plugin_dir_path( $plugin_file );
22
23			// setup autoloader.
24			require_once 'include/EmailLogAutoloader.php';
25
26			$loader = new \EmailLog\EmailLogAutoloader();
27			$loader->add_namespace( 'EmailLog', $plugin_dir . 'include' );
28
29			if ( file_exists( $plugin_dir . 'tests/' ) ) {
30			// if tests are present, then add them.
31			$loader->add_namespace( 'EmailLog', $plugin_dir . 'tests/wp-tests' );
32			}
33
34			$loader->add_file( $plugin_dir . 'include/Util/helper.php' );
35			$loader->add_file( $plugin_dir . 'include/Addon/addon-helper.php' );
36
37			$loader->register();
38
39			$email_log = new \EmailLog\Core\EmailLog( $plugin_file, $loader, new \EmailLog\Core\DB\TableManager() );
40
41			if ( \EmailLog\Util\is_admin_non_ajax_request() ) {
42			// Loading licenser in frontend or ajax request is resulting in huge performance issues.
43			$email_log->set_licenser( new \EmailLog\Addon\License\Licenser() );
44
45			$email_log->add_loadie( new \EmailLog\Addon\DependencyEnforcer() );
46			$email_log->add_loadie( new \EmailLog\Core\Request\OverridePluginAPI() );
47			}
48
49			$email_log->add_loadie( new \EmailLog\Core\EmailLogger() );
50			$email_log->add_loadie( new \EmailLog\Core\UI\UILoader() );
51			$email_log->add_loadie( new \EmailLog\Core\UI\Setting\EmailLogSetting() );
			0 ignored issues – show Documentation introduced 2017-09-12 17:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \EmailLog\Core\UI\Setting\EmailLogSetting()` is of type `object<EmailLog\Core\UI\Setting\EmailLogSetting>`, but the function expects a `object<EmailLog\Core\Loadie>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52
53			$email_log->add_loadie( new \EmailLog\Core\Request\NonceChecker() );
54			$email_log->add_loadie( new \EmailLog\Core\Request\LogListAction() );
55			$email_log->add_loadie( new \EmailLog\Core\Request\OverridePluginAPI() );
56
57			// `register_activation_hook` can't be called from inside any hook.
58			register_activation_hook( $plugin_file, array( $email_log->table_manager, 'on_activate' ) );
59
60			// Ideally the plugin should be loaded in a later event like `init` or `wp_loaded`.
61			// But some plugins like EDD are sending emails in `init` event itself,
62			// which won't be logged if the plugin is loaded in `wp_loaded` or `init`.
63			add_action( 'plugins_loaded', array( $email_log, 'load' ), 101 );
64			}
65
66			/**
67			* Return the global instance of Email Log plugin.
68			* Eventually the EmailLog class might become singleton.
69			*
70			* @since 2.0
71			*
72			* @global \EmailLog\Core\EmailLog $email_log
73			* @return \EmailLog\Core\EmailLog
74			*/
75			function email_log() {
76			global $email_log;
77
78			return $email_log;
79			}
80

sudar / email-log

Push — dev/2.1.0 ( 39cfde...c5edab )

load-email-log.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like