subjective-php / spl-traits

tests/MagicPropertyDisabledTraitTest.php

<?php

namespace SubjectivePHPTest\Spl\Traits;

use SubjectivePHP\Spl\Traits\MagicPropertyDisabledTrait;

/**
 * @coversDefaultClass SubjectivePHP\Spl\Traits\MagicPropertyDisabledTrait
 */
class MagicPropertyDisabledTraitTest extends \PHPUnit\Framework\TestCase
{
    /**
     * @test
     * @covers ::__get
     * @expectedException \BadMethodCallException
     */
    public function magicGet()
    {
        $object = $this->getObjectForTrait(MagicPropertyDisabledTrait::class);
        $foo = $object->foo;

Accessing foo on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

$foo is not used, you could remove the assignment.

    }

    /**
     * @test
     * @covers ::__set
     * @expectedException \BadMethodCallException
     */
    public function magicSet()
    {
        $object = $this->getObjectForTrait(MagicPropertyDisabledTrait::class);
        $object->foo = 'bar';

Accessing foo on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}