Issues in RedisCacheTest.php (master) - Issues in master - subjective-php/psr-cache-redis - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/RedisCacheTest.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SubjectivePHPTest\Psr\SimpleCache;

use DateTime;
use SubjectivePHP\Psr\SimpleCache\RedisCache;
use Predis\Client;

/**
 * @coversDefaultClass \SubjectivePHP\Psr\SimpleCache\RedisCache
 * @covers ::__construct
 * @covers ::<private>
 */
final class RedisCacheTest extends \PHPUnit\Framework\TestCase
{
    /**
     * @var Client
     */
    private $predis;

    /**
     * @var RedisCache
     */
    private $cache;

    /**
     * @return void
     */
    public function setUp()
    {
        $this->predis = new Client();
        $this->predis->flushall();
        $this->cache = new RedisCache($this->predis);
    }

    /**
     * @test
     * @covers ::get
     *
     * @return void
     */
    public function get()
    {
        $dateTime = new DateTime();
        $this->predis->set('foo', serialize($dateTime));
        $this->assertEquals($dateTime, $this->cache->get('foo'));
    }

    /**
     * @test
     * @covers ::get
     *
     * @return void
     */
    public function getKeyNotFound()
    {
        $default = new \StdClass();
        $this->assertSame($default, $this->cache->get('foo', $default));
    }

    /**
     * @test
     * @covers ::getMultiple
     *
     * @return void
     */
    public function getMultple()
    {
        $default = new \StdClass();
        $dateTime = new \DateTime();
        $exception = new \RuntimeException();
        $this->predis->set('foo', serialize($dateTime));
        $this->predis->set('bar', serialize($exception));
        $actual = $this->cache->getMultiple(['foo', 'baz', 'bar'], $default);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals($dateTime, $actual['foo']);
        $this->assertSame($default, $actual['baz']);
        $this->assertEquals($exception, $actual['bar']);
    }

    /**
     * @test
     * @covers ::set
     *
     * @return void
     */
    public function set()
    {
        $dateTime = new \DateTime();
        $this->assertTrue($this->cache->set('foo', $dateTime, 3600));
        $ttl = $this->predis->ttl('foo');
        $this->assertSame(serialize($dateTime), $this->predis->get('foo'));
        $this->assertGreaterThan(3598, $ttl);
        $this->assertLessThanOrEqual(3600, $ttl);
    }

    /**
     * @test
     * @covers ::set
     *
     * @return void
     */
    public function setFails()
    {
        $mockPredis = $this->getMockBuilder('\\Predis\\ClientInterface')->getMock();
        $mockPredis->expects($this->once())->method('__call')->willReturn(new \Predis\Response\Status('Not OK'));
        $cache = new RedisCache($mockPredis);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertFalse($cache->set('foo', new \DateTime(), 3600));
    }

    /**
     * @test
     * @covers ::setMultiple
     *
     * @return void
     */
    public function setMultple()
    {
        $dateTime = new \DateTime();
        $exception = new \RuntimeException();
        $this->assertTrue($this->cache->setMultiple(['foo' => $dateTime, 'bar' => $exception]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame(serialize($dateTime), $this->predis->get('foo'));
        $this->assertSame(serialize($exception), $this->predis->get('bar'));
    }

    /**
     * @test
     * @covers ::setMultiple
     *
     * @return void
     */
    public function setMultpleFails()
    {
        $passStatus = new \Predis\Response\Status('OK');
        $failStatus = new \Predis\Response\Status('Not OK');

        $mockPredis = $this->getMockBuilder('\\Predis\\ClientInterface')->getMock();
        $mockPredis->expects($this->exactly(3))->method('__call')->withConsecutive(
            [$this->equalTo('set'), $this->anything()],
            [$this->equalTo('expireat'), $this->anything()],
            [$this->equalTo('set'), $this->anything()]
        )->will($this->onConsecutiveCalls($passStatus, true, $failStatus));
        $cache = new RedisCache($mockPredis);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertFalse(
            $cache->setMultiple(
                ['foo' => new \DateTime(), 'bar' => new \DateTime()],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                \DateInterval::createFromDateString('1 day')
            )
        );
    }

    /**
     * @test
     * @covers ::delete
     *
     * @return void
     */
    public function delete()
    {
        $dateTime = new DateTime();
        $this->predis->set('foo', serialize($dateTime));
        $this->cache->delete('foo');
        $this->assertSame(0, $this->predis->exists('foo'));
    }

    /**
     * @test
     * @covers ::deleteMultiple
     *
     * @return void
     */
    public function deleteMultiple()
    {
        $this->predis->set('foo', 'foo');
        $this->predis->set('bar', 'bar');
        $this->predis->set('baz', 'baz');

        $this->cache->deleteMultiple(['foo', 'bar']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame(0, $this->predis->exists('foo'));
        $this->assertSame(0, $this->predis->exists('bar'));
        $this->assertSame(1, $this->predis->exists('baz'));
    }

    /**
     * @test
     * @covers ::clear
     *
     * @return void
     */
    public function clear()
    {
        $this->predis->set('foo', 'foo');
        $this->predis->set('bar', 'bar');
        $this->predis->set('baz', 'baz');

        $this->cache->clear();
        $this->assertSame(0, $this->predis->exists('foo'));
        $this->assertSame(0, $this->predis->exists('bar'));
        $this->assertSame(0, $this->predis->exists('baz'));
    }

    /**
     * @test
     * @covers ::has
     *
     * @return void
     */
    public function has()
    {
        $this->predis->set('foo', 'foo');
        $this->assertTrue($this->cache->has('foo'));
        $this->assertFalse($this->cache->has('bar'));
    }
}


1		<?php
2
3		namespace SubjectivePHPTest\Psr\SimpleCache;
4
5		use DateTime;
6		use SubjectivePHP\Psr\SimpleCache\RedisCache;
7		use Predis\Client;
8
9		/**
10		* @coversDefaultClass \SubjectivePHP\Psr\SimpleCache\RedisCache
11		* @covers ::__construct
12		* @covers ::<private>
13		*/
14		final class RedisCacheTest extends \PHPUnit\Framework\TestCase
15		{
16		/**
17		* @var Client
18		*/
19		private $predis;
20
21		/**
22		* @var RedisCache
23		*/
24		private $cache;
25
26		/**
27		* @return void
28		*/
29		public function setUp()
30		{
31		$this->predis = new Client();
32		$this->predis->flushall();
33		$this->cache = new RedisCache($this->predis);
34		}
35
36		/**
37		* @test
38		* @covers ::get
39		*
40		* @return void
41		*/
42		public function get()
43		{
44		$dateTime = new DateTime();
45		$this->predis->set('foo', serialize($dateTime));
46		$this->assertEquals($dateTime, $this->cache->get('foo'));
47		}
48
49		/**
50		* @test
51		* @covers ::get
52		*
53		* @return void
54		*/
55		public function getKeyNotFound()
56		{
57		$default = new \StdClass();
58		$this->assertSame($default, $this->cache->get('foo', $default));
59		}
60
61		/**
62		* @test
63		* @covers ::getMultiple
64		*
65		* @return void
66		*/
67		public function getMultple()
68		{
69		$default = new \StdClass();
70		$dateTime = new \DateTime();
71		$exception = new \RuntimeException();
72		$this->predis->set('foo', serialize($dateTime));
73		$this->predis->set('bar', serialize($exception));
74		$actual = $this->cache->getMultiple(['foo', 'baz', 'bar'], $default);
		0 ignored issues – show Documentation introduced 2018-07-15 16:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('foo', 'baz', 'bar')` is of type `array<integer,string,{"0..."string","2":"string"}>`, but the function expects a `object<SubjectivePHP\Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75		$this->assertEquals($dateTime, $actual['foo']);
76		$this->assertSame($default, $actual['baz']);
77		$this->assertEquals($exception, $actual['bar']);
78		}
79
80		/**
81		* @test
82		* @covers ::set
83		*
84		* @return void
85		*/
86		public function set()
87		{
88		$dateTime = new \DateTime();
89		$this->assertTrue($this->cache->set('foo', $dateTime, 3600));
90		$ttl = $this->predis->ttl('foo');
91		$this->assertSame(serialize($dateTime), $this->predis->get('foo'));
92		$this->assertGreaterThan(3598, $ttl);
93		$this->assertLessThanOrEqual(3600, $ttl);
94		}
95
96		/**
97		* @test
98		* @covers ::set
99		*
100		* @return void
101		*/
102		public function setFails()
103		{
104		$mockPredis = $this->getMockBuilder('\\Predis\\ClientInterface')->getMock();
105		$mockPredis->expects($this->once())->method('__call')->willReturn(new \Predis\Response\Status('Not OK'));
106		$cache = new RedisCache($mockPredis);
		0 ignored issues – show Documentation introduced 2018-07-15 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$mockPredis` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Predis\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107		$this->assertFalse($cache->set('foo', new \DateTime(), 3600));
108		}
109
110		/**
111		* @test
112		* @covers ::setMultiple
113		*
114		* @return void
115		*/
116		public function setMultple()
117		{
118		$dateTime = new \DateTime();
119		$exception = new \RuntimeException();
120		$this->assertTrue($this->cache->setMultiple(['foo' => $dateTime, 'bar' => $exception]));
		0 ignored issues – show Documentation introduced 2018-07-15 16:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('foo' => $dateTime, 'bar' => $exception)` is of type `array<string,object<Date...ct<RuntimeException>"}>`, but the function expects a `object<SubjectivePHP\Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
121		$this->assertSame(serialize($dateTime), $this->predis->get('foo'));
122		$this->assertSame(serialize($exception), $this->predis->get('bar'));
123		}
124
125		/**
126		* @test
127		* @covers ::setMultiple
128		*
129		* @return void
130		*/
131		public function setMultpleFails()
132		{
133		$passStatus = new \Predis\Response\Status('OK');
134		$failStatus = new \Predis\Response\Status('Not OK');
135
136		$mockPredis = $this->getMockBuilder('\\Predis\\ClientInterface')->getMock();
137		$mockPredis->expects($this->exactly(3))->method('__call')->withConsecutive(
138		[$this->equalTo('set'), $this->anything()],
139		[$this->equalTo('expireat'), $this->anything()],
140		[$this->equalTo('set'), $this->anything()]
141		)->will($this->onConsecutiveCalls($passStatus, true, $failStatus));
142		$cache = new RedisCache($mockPredis);
		0 ignored issues – show Documentation introduced 2018-07-15 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$mockPredis` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Predis\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
143		$this->assertFalse(
144		$cache->setMultiple(
145		['foo' => new \DateTime(), 'bar' => new \DateTime()],
		0 ignored issues – show Documentation introduced 2018-07-15 16:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('foo' => new \Date...ar' => new \DateTime())` is of type `array<string,object<Date...r":"object<DateTime>"}>`, but the function expects a `object<SubjectivePHP\Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
146		\DateInterval::createFromDateString('1 day')
147		)
148		);
149		}
150
151		/**
152		* @test
153		* @covers ::delete
154		*
155		* @return void
156		*/
157		public function delete()
158		{
159		$dateTime = new DateTime();
160		$this->predis->set('foo', serialize($dateTime));
161		$this->cache->delete('foo');
162		$this->assertSame(0, $this->predis->exists('foo'));
163		}
164
165		/**
166		* @test
167		* @covers ::deleteMultiple
168		*
169		* @return void
170		*/
171	View Code Duplication	public function deleteMultiple()
172		{
173		$this->predis->set('foo', 'foo');
174		$this->predis->set('bar', 'bar');
175		$this->predis->set('baz', 'baz');
176
177		$this->cache->deleteMultiple(['foo', 'bar']);
		0 ignored issues – show Documentation introduced 2018-07-15 16:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('foo', 'bar')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `object<SubjectivePHP\Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
178		$this->assertSame(0, $this->predis->exists('foo'));
179		$this->assertSame(0, $this->predis->exists('bar'));
180		$this->assertSame(1, $this->predis->exists('baz'));
181		}
182
183		/**
184		* @test
185		* @covers ::clear
186		*
187		* @return void
188		*/
189	View Code Duplication	public function clear()
190		{
191		$this->predis->set('foo', 'foo');
192		$this->predis->set('bar', 'bar');
193		$this->predis->set('baz', 'baz');
194
195		$this->cache->clear();
196		$this->assertSame(0, $this->predis->exists('foo'));
197		$this->assertSame(0, $this->predis->exists('bar'));
198		$this->assertSame(0, $this->predis->exists('baz'));
199		}
200
201		/**
202		* @test
203		* @covers ::has
204		*
205		* @return void
206		*/
207		public function has()
208		{
209		$this->predis->set('foo', 'foo');
210		$this->assertTrue($this->cache->has('foo'));
211		$this->assertFalse($this->cache->has('bar'));
212		}
213		}
214

subjective-php / psr-cache-redis

Issues (10)

Security Analysis no request data

tests/RedisCacheTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like