encryptWithPaddingAeadMode - Code Metrics - Inspection of "Really made namespaces a thing" - stymiee/php-simple-encryption - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (b41ac8)

by John

created 2020-05-11 15:10 UTC

encryptWithPaddingAeadMode A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	8
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	0
dl	8
loc	8
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	encrypt()	5	5	1

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace Encryption\Traits;


trait encryptWithPaddingAeadMode

{
    public function encrypt(string $plainText, string $key, string $iv, &$tag): string
    {
        $plainText = $this->getPaddedText($plainText, static::BLOCK_SIZE);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return base64_encode(openssl_encrypt($plainText, static::CIPHER, $key, OPENSSL_RAW_DATA, $iv, $tag));
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Encryption\Traits;
6
7
8	View Code Duplication	trait encryptWithPaddingAeadMode
		0 ignored issues – show Coding Style introduced 2020-05-11 13:01 UTC by Report Bug Copy Issue Report `encryptWithPaddingAeadMode` does not seem to conform to the naming convention (`^[A-Z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Duplication introduced 2020-05-11 13:01 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		public function encrypt(string $plainText, string $key, string $iv, &$tag): string
11		{
12		$plainText = $this->getPaddedText($plainText, static::BLOCK_SIZE);
		0 ignored issues – show Bug introduced 2020-05-11 13:01 UTC by Report Bug Copy Issue Report It seems like `getPaddedText()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Coding Style introduced 2020-05-11 13:01 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$plainText`. This often makes code more readable. Loading history...
13		return base64_encode(openssl_encrypt($plainText, static::CIPHER, $key, OPENSSL_RAW_DATA, $iv, $tag));
14		}
15		}
16

stymiee / php-simple-encryption

Branch — master (b41ac8)

encryptWithPaddingAeadMode A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like