stwalkerster / waca

includes/Pages/PageDomainSwitch.php

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Pages;

use Waca\DataObjects\Domain;
use Waca\DataObjects\User;
use Waca\Router\RequestRouter;
use Waca\Tasks\InternalPageBase;
use Waca\WebRequest;

class PageDomainSwitch extends InternalPageBase
{
    /**
     * @inheritDoc
     */
    protected function main()
    {
        if (!WebRequest::wasPosted()) {
            $this->redirect('/');

            return;
        }

        $database = $this->getDatabase();
        $currentUser = User::getCurrent($database);

        /** @var Domain|false $newDomain */
        $newDomain = Domain::getById(WebRequest::postInt('newdomain'), $database);

        if ($newDomain === false) {

The condition $newDomain === false is always false.

            $this->redirect('/');

            return;
        }

        $this->getDomainAccessManager()->switchDomain($currentUser, $newDomain);

        // try to stay on the same page if possible.
        // This only checks basic ACLs and not domain privileges, so this may still result in a 403.

        $referrer = WebRequest::postString('referrer');
        $priorPath = explode('/', $referrer);

It seems like $referrer can also be of type null; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        $router = new RequestRouter();
        $route = $router->getRouteFromPath($priorPath);

        if ($this->barrierTest($route[1], $currentUser, $route[0])) {
            $this->redirect('/' . $referrer);
        } else {
            $this->redirect('/');
        }
    }
}