Issues in StatsInactiveUsers.php - New Issues - Inspection of "Inactivity changes to hide recently-approved users..." - stwalkerster/waca - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 04d19a...743d3f )

by Simon

created 2017-08-16 22:16 UTC

includes/statistics/StatsInactiveUsers.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**************************************************************************
**********      English Wikipedia Account Request Interface      **********
***************************************************************************
** Wikipedia Account Request Graphic Design by Charles Melbye,           **
** which is licensed under a Creative Commons                            **
** Attribution-Noncommercial-Share Alike 3.0 United States License.      **
**                                                                       **
** All other code are released under the Public Domain                   **
** by the ACC Development Team.                                          **
**                                                                       **
** See CREDITS for the list of developers.                               **
***************************************************************************/

class StatsInactiveUsers extends StatisticsPage
{
	protected function execute()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		global $smarty;
function myFunction($a, $b) {
    // Do something
}

		// this is horrible.
		// yes, there is business logic in the templates
		// yes, there was some there before
		// yes, I have just added to it.
		//
		// I'm sorry.
		//
		// newinternal will fix this.
		$date = new DateTime();
		$date->modify("-90 days");

		$smarty->assign('datelimit', $date);

		$showImmune = false;
		if (isset($_GET['showimmune'])) {
			$showImmune = true;
		}
		$smarty->assign("showImmune", $showImmune);

		$inactiveUsers = User::getAllInactive(gGetDb());

		$smarty->assign("inactiveUsers", $inactiveUsers);

		return $smarty->fetch("statistics/inactiveusers.tpl");
	}

	public function getPageName()
	{
		return "InactiveUsers";
	}

	public function getPageTitle()
	{
		return "Inactive tool users";
	}

	public function isProtected()
	{
		return true;
	}

	public function requiresWikiDatabase()
	{
		return false;
	}
}


1			<?php
2			/**************************************************************************
3			******** English Wikipedia Account Request Interface ********
4			***************************************************************************
5			Wikipedia Account Request Graphic Design by Charles Melbye,
6			which is licensed under a Creative Commons
7			Attribution-Noncommercial-Share Alike 3.0 United States License.
8
9			All other code are released under the Public Domain
10			by the ACC Development Team.
11
12			See CREDITS for the list of developers.
13			***************************************************************************/
14
15			class StatsInactiveUsers extends StatisticsPage
16			{
17			protected function execute()
			0 ignored issues – show Coding Style introduced 2017-08-16 22:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `execute` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
18			{
19			global $smarty;
			0 ignored issues – show Compatibility Best Practice introduced 2017-08-16 22:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
20
21			// this is horrible.
22			// yes, there is business logic in the templates
23			// yes, there was some there before
24			// yes, I have just added to it.
25			//
26			// I'm sorry.
27			//
28			// newinternal will fix this.
29			$date = new DateTime();
30			$date->modify("-90 days");
31
32			$smarty->assign('datelimit', $date);
33
34			$showImmune = false;
35			if (isset($_GET['showimmune'])) {
36			$showImmune = true;
37			}
38			$smarty->assign("showImmune", $showImmune);
39
40			$inactiveUsers = User::getAllInactive(gGetDb());
41
42			$smarty->assign("inactiveUsers", $inactiveUsers);
43
44			return $smarty->fetch("statistics/inactiveusers.tpl");
45			}
46
47			public function getPageName()
48			{
49			return "InactiveUsers";
50			}
51
52			public function getPageTitle()
53			{
54			return "Inactive tool users";
55			}
56
57			public function isProtected()
58			{
59			return true;
60			}
61
62			public function requiresWikiDatabase()
63			{
64			return false;
65			}
66			}
67

stwalkerster / waca

Push — master ( 04d19a...743d3f )

includes/statistics/StatsInactiveUsers.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like