ApiRequestRouter::route() - Code Metrics - Inspection of "refactor logging retrieval/display code out of Log..." - stwalkerster/waca - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Branch — newinternal (104de7)

by Simon

created 2016-03-26 04:01 UTC

ApiRequestRouter::route() B

↳ Parent: ApiRequestRouter

Complexity

Conditions	6
Paths	6

Size

Total Lines	27
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	27
rs	8.439
cc	6
eloc	22
nc	6
nop	0

<?php

namespace Waca\Router;

use Exception;
use Waca\API\Actions\CountAction;
use Waca\API\Actions\HelpAction;
use Waca\API\Actions\MonitorAction;
use Waca\API\Actions\StatsAction;
use Waca\API\Actions\StatusAction;
use Waca\API\Actions\UnknownAction;
use Waca\Tasks\IRoutedTask;
use Waca\WebRequest;

class ApiRequestRouter implements IRequestRouter
{
	/**
	 * @return string[]
	 */
	public static function getActionList()
	{
		return array("count", "status", "stats", "help", "monitor");
	}

	/**
	 * @return IRoutedTask

	 * @throws Exception
	 */
	public function route()
	{
		$requestAction = WebRequest::getString('action');

		switch ($requestAction) {
			case "count":
				$result = new CountAction();
				break;
			case "status":
				$result = new StatusAction();
				break;
			case "stats":
				$result = new StatsAction();
				break;
			case "help":
				$result = new HelpAction();
				break;
			case "monitor":
				$result = new MonitorAction();
				break;
			default:
				$result = new UnknownAction();
				break;
		}

		return $result;
	}
}

1			<?php
2
3			namespace Waca\Router;
4
5			use Exception;
6			use Waca\API\Actions\CountAction;
7			use Waca\API\Actions\HelpAction;
8			use Waca\API\Actions\MonitorAction;
9			use Waca\API\Actions\StatsAction;
10			use Waca\API\Actions\StatusAction;
11			use Waca\API\Actions\UnknownAction;
12			use Waca\Tasks\IRoutedTask;
13			use Waca\WebRequest;
14
15			class ApiRequestRouter implements IRequestRouter
16			{
17			/**
18			* @return string[]
19			*/
20			public static function getActionList()
21			{
22			return array("count", "status", "stats", "help", "monitor");
23			}
24
25			/**
26			* @return IRoutedTask
			0 ignored issues – show Documentation introduced 2016-03-26 04:10 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `CountAction\|StatusAction...elpAction\|MonitorAction`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
27			* @throws Exception
28			*/
29			public function route()
30			{
31			$requestAction = WebRequest::getString('action');
32
33			switch ($requestAction) {
34			case "count":
35			$result = new CountAction();
36			break;
37			case "status":
38			$result = new StatusAction();
39			break;
40			case "stats":
41			$result = new StatsAction();
42			break;
43			case "help":
44			$result = new HelpAction();
45			break;
46			case "monitor":
47			$result = new MonitorAction();
48			break;
49			default:
50			$result = new UnknownAction();
51			break;
52			}
53
54			return $result;
55			}
56			}

stwalkerster / waca

Branch — newinternal (104de7)

ApiRequestRouter::route() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like