GlobalStateProvider - Code Metrics - Inspection of "Implement private data barrier" - stwalkerster/waca - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Branch — newinternal (3df7fe)

by Simon

created 2016-04-08 00:15 UTC

GlobalStateProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	4
c	1
b	0
f	1
lcom	0
cbo	0
dl	0
loc	34
ccs	0
cts	8
cp	0
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getServerSuperGlobal()	4	1
A	getGetSuperGlobal()	4	1
A	getPostSuperGlobal()	4	1
A	getSessionSuperGlobal()	4	1

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Providers\GlobalState;

/**
 * Class GlobalStateProvider
 *
 * DO NOT USE THIS CLASS.
 * (Unless your name is <something>Test or WebRequest).
 *
 * @package Waca\Providers
 */
class GlobalStateProvider implements IGlobalStateProvider
{
	/**
	 * @return array
	 */
	public function &getServerSuperGlobal()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		return $_SERVER;
	}

	/**
	 * @return array
	 */
	public function &getGetSuperGlobal()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		return $_GET;
	}

	/**
	 * @return array
	 */
	public function &getPostSuperGlobal()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		return $_POST;
	}

	/**
	 * @return array
	 */
	public function &getSessionSuperGlobal()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		return $_SESSION;
	}
}

1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\Providers\GlobalState;
10
11			/**
12			* Class GlobalStateProvider
13			*
14			* DO NOT USE THIS CLASS.
15			* (Unless your name is <something>Test or WebRequest).
16			*
17			* @package Waca\Providers
18			*/
19			class GlobalStateProvider implements IGlobalStateProvider
20			{
21			/**
22			* @return array
23			*/
24			public function &getServerSuperGlobal()
			0 ignored issues – show Coding Style introduced 2016-03-24 00:40 UTC by Report Bug Copy Issue Report `getServerSuperGlobal` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25			{
26			return $_SERVER;
27			}
28
29			/**
30			* @return array
31			*/
32			public function &getGetSuperGlobal()
			0 ignored issues – show Coding Style introduced 2016-03-24 00:40 UTC by Report Bug Copy Issue Report `getGetSuperGlobal` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33			{
34			return $_GET;
35			}
36
37			/**
38			* @return array
39			*/
40			public function &getPostSuperGlobal()
			0 ignored issues – show Coding Style introduced 2016-03-24 00:40 UTC by Report Bug Copy Issue Report `getPostSuperGlobal` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
41			{
42			return $_POST;
43			}
44
45			/**
46			* @return array
47			*/
48			public function &getSessionSuperGlobal()
			0 ignored issues – show Coding Style introduced 2016-03-24 00:40 UTC by Report Bug Copy Issue Report `getSessionSuperGlobal` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49			{
50			return $_SESSION;
51			}
52			}

stwalkerster / waca

Branch — newinternal (3df7fe)

GlobalStateProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like