Waca\DataObjects\Log

Complexity

Total Complexity

16

Size/Duplication

Total Lines	155
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
B	save()	0	26	3
A	delete()	0	4	1
A	getObjectId()	0	4	1
A	setObjectId()	0	4	1
A	getObjectType()	0	4	1
A	setObjectType()	0	4	1
A	getUser()	0	4	1
A	setUser()	0	9	2
A	getAction()	0	4	1
A	setAction()	0	4	1
A	getTimestamp()	0	4	1
A	getComment()	0	4	1
A	setComment()	0	4	1

<?php
namespace Waca\DataObjects;

use DateTimeImmutable;
use Exception;
use Waca\DataObject;

/**
 * Class representing a log entry
 */
class Log extends DataObject
{
	/** @var int */
	private $objectid;
	/** @var string */
	private $objecttype;
	/** @var int */
	private $user;
	/** @var string */
	private $action;
	private $timestamp;
	/** @var string|null */
	private $comment;

	/**
	 * @throws Exception
	 */
	public function save()
	{
		if ($this->isNew()) {
			$statement = $this->dbObject->prepare(<<<SQL
                INSERT INTO log (objectid, objecttype, user, action, timestamp, comment) 
                VALUES (:id, :type, :user, :action, CURRENT_TIMESTAMP(), :comment);
SQL
			);

			$statement->bindValue(":id", $this->objectid);
			$statement->bindValue(":type", $this->objecttype);
			$statement->bindValue(":user", $this->user);
			$statement->bindValue(":action", $this->action);
			$statement->bindValue(":comment", $this->comment);

			if ($statement->execute()) {
				$this->id = $this->dbObject->lastInsertId();

The property $id was declared of type integer, but $this->dbObject->lastInsertId() is of type string. Maybe add a type cast?

			}
			else {
				throw new Exception($statement->errorInfo());
			}
		}
		else {
			throw new Exception("Updating logs is not available");
		}
	}

	/**
	 * @throws Exception
	 */
	public function delete()
	{
		throw new Exception("Deleting logs is not available.");
	}

	/**
	 * @return int
	 */
	public function getObjectId()
	{
		return $this->objectid;
	}

	/**
	 * Summary of setObjectId
	 *
	 * @param int $objectId
	 */
	public function setObjectId($objectId)
	{
		$this->objectid = $objectId;
	}

	/**
	 * @return string
	 */
	public function getObjectType()
	{
		return $this->objecttype;
	}

	/**
	 * Summary of setObjectType
	 *
	 * @param string $objectType
	 */
	public function setObjectType($objectType)
	{
		$this->objecttype = $objectType;
	}

	/**
	 * @return int
	 */
	public function getUser()
	{
		return $this->user;
	}

	/**
	 * Summary of setUser
	 *
	 * @param User|integer $user
	 */
	public function setUser($user)
	{
		if (is_a($user, User::class)) {
			$this->user = $user->getId();

It seems like $user is not always an object, but can also be of type integer. Maybe add an additional type check?

		}
		else {
			$this->user = $user;

It seems like $user can also be of type object<Waca\DataObjects\User>. However, the property $user is declared as type integer. Maybe add an additional type check?

		}
	}

	/**
	 * @return string
	 */
	public function getAction()
	{
		return $this->action;
	}

	/**
	 * Summary of setAction
	 *
	 * @param string $action
	 */
	public function setAction($action)
	{
		$this->action = $action;
	}

	/**
	 * @return DateTimeImmutable
	 */
	public function getTimestamp()
	{
		return new DateTimeImmutable($this->timestamp);
	}

	/**
	 * @return string|null
	 */
	public function getComment()
	{
		return $this->comment;
	}

	/**
	 * Summary of setComment
	 *
	 * @param string $comment
	 */
	public function setComment($comment)
	{
		$this->comment = $comment;
	}
}