Complex classes like CommunityUser often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CommunityUser, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 6 | class CommunityUser extends User |
||
| 7 | { |
||
| 8 | public function getId() |
||
| 12 | |||
| 13 | public function save() |
||
| 17 | |||
| 18 | public function authenticate($password) |
||
| 23 | |||
| 24 | public function touchLastLogin() |
||
| 27 | |||
| 28 | #region properties |
||
| 29 | |||
| 30 | public function getUsername() |
||
| 35 | |||
| 36 | public function setUsername($username) |
||
| 39 | |||
| 40 | public function getEmail() |
||
| 45 | |||
| 46 | public function setEmail($email) |
||
| 49 | |||
| 50 | public function setPassword($password) |
||
| 53 | |||
| 54 | public function getStatus() |
||
| 58 | |||
| 59 | public function getOnWikiName() |
||
| 63 | |||
| 64 | public function getStoredOnWikiName() |
||
| 68 | |||
| 69 | public function setOnWikiName($onWikiName) |
||
| 72 | |||
| 73 | public function getWelcomeSig() |
||
| 77 | |||
| 78 | public function setWelcomeSig($welcomeSig) |
||
| 81 | |||
| 82 | public function getLastActive() |
||
| 87 | |||
| 88 | public function setLastActive($lastActive) |
||
| 91 | |||
| 92 | public function getForcelogout() |
||
| 96 | |||
| 97 | public function setForcelogout($forceLogout) |
||
| 100 | |||
| 101 | public function getSecure() |
||
| 105 | |||
| 106 | /** |
||
| 107 | * @return int |
||
| 108 | */ |
||
| 109 | public function getCheckuser() |
||
| 113 | |||
| 114 | public function setCheckuser($checkuser) |
||
| 117 | |||
| 118 | public function getIdentified() |
||
| 122 | |||
| 123 | public function setIdentified($identified) |
||
| 126 | |||
| 127 | public function getWelcomeTemplate() |
||
| 131 | |||
| 132 | public function setWelcomeTemplate($welcomeTemplate) |
||
| 135 | |||
| 136 | public function getAbortPref() |
||
| 140 | |||
| 141 | public function setAbortPref($abortPreference) |
||
| 144 | |||
| 145 | public function getConfirmationDiff() |
||
| 149 | |||
| 150 | public function setConfirmationDiff($confirmationDiff) |
||
| 153 | |||
| 154 | public function getEmailSig() |
||
| 158 | |||
| 159 | public function setEmailSig($emailSignature) |
||
| 162 | |||
| 163 | #endregion |
||
| 164 | |||
| 165 | #region changing access level |
||
| 166 | public function approve() |
||
| 169 | |||
| 170 | public function suspend($comment) |
||
| 173 | |||
| 174 | public function decline($comment) |
||
| 177 | |||
| 178 | public function promote() |
||
| 181 | |||
| 182 | public function demote($comment) |
||
| 185 | |||
| 186 | #endregion |
||
| 187 | |||
| 188 | #region user access checks |
||
| 189 | |||
| 190 | public function isAdmin() |
||
| 194 | |||
| 195 | public function isCheckuser() |
||
| 199 | |||
| 200 | public function isSuspended() |
||
| 204 | |||
| 205 | public function isNew() |
||
| 209 | |||
| 210 | public function isUser() |
||
| 214 | |||
| 215 | public function isDeclined() |
||
| 219 | |||
| 220 | public function isCommunityUser() |
||
| 224 | |||
| 225 | #endregion |
||
| 226 | |||
| 227 | #region OAuth |
||
| 228 | |||
| 229 | public function getOAuthIdentity($useCached = false) |
||
| 233 | |||
| 234 | public function isOAuthLinked() |
||
| 238 | |||
| 239 | public function detachAccount() |
||
| 242 | |||
| 243 | public function oauthCanUse() |
||
| 247 | |||
| 248 | public function oauthCanEdit() |
||
| 252 | |||
| 253 | public function oauthCanCreateAccount() |
||
| 257 | |||
| 258 | protected function oauthCanCheckUser() |
||
| 262 | |||
| 263 | #endregion |
||
| 264 | |||
| 265 | public function getApprovalDate() |
||
| 270 | } |
||
| 271 |
Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a
@returnannotation as described here.