RequestQueueHelper::configureDefaults() - Code Metrics - Inspection of "Point antispoof centralauth check to meta (#758)" - stwalkerster/waca - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3e5dae...8d4e4c )

by Simon

created 2022-08-16 11:32 UTC

RequestQueueHelper::configureDefaults() C

↳ Parent: RequestQueueHelper

Complexity

Conditions	12
Paths	4

Size

Total Lines	22
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	22
rs	6.9666
cc	12
nc	4
nop	6

How to fix Complexity

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Helpers;

use Waca\DataObjects\EmailTemplate;
use Waca\DataObjects\RequestForm;
use Waca\DataObjects\RequestQueue;
use Waca\PdoDatabase;

class RequestQueueHelper
{
    /**
     * @param RequestQueue $queue
     * @param bool         $enabled
     * @param bool         $default
     * @param bool         $antiSpoof
     * @param bool         $titleBlacklist
     */
    public function configureDefaults(
        RequestQueue $queue,
        bool $enabled,
        bool $default,
        bool $antiSpoof,
        bool $titleBlacklist,
        bool $isTarget
    ) {
        // always allow enabling a queue
        if ($enabled) {
            $queue->setEnabled($enabled);
        }

        // only allow other enable-flag changes if we're not a default
        if (!($queue->isDefault() || $queue->isDefaultAntispoof() || $queue->isDefaultTitleBlacklist() || $isTarget)) {
            $queue->setEnabled($enabled);
        }

        // only allow enabling the default flags, and only when we're enabled.
        $queue->setDefault(($queue->isDefault() || $default) && $queue->isEnabled());
        $queue->setDefaultAntispoof(($queue->isDefaultAntispoof() || $antiSpoof) && $queue->isEnabled());
        $queue->setDefaultTitleBlacklist(($queue->isDefaultTitleBlacklist() || $titleBlacklist) && $queue->isEnabled());
    }

    /**
     * @param RequestQueue $queue
     * @param PdoDatabase  $database
     *
     * @return bool
     */
    public function isEmailTemplateTarget(RequestQueue $queue, PdoDatabase $database): bool
    {
        $isTarget = false;
        /** @var EmailTemplate[] $deferralTemplates */
        $deferralTemplates = EmailTemplate::getAllActiveTemplates('defer', $database);
        foreach ($deferralTemplates as $t) {
            if ($t->getQueue() === $queue->getId()) {
                $isTarget = true;
                break;
            }
        }

        return $isTarget;
    }

    public function isRequestFormTarget(RequestQueue $queue, PdoDatabase $database): bool
    {
        $isTarget = false;
        $forms = RequestForm::getAllForms($database, 1); // FIXME: domains
        foreach ($forms as $t) {
            if ($t->isEnabled()) {
                if ($t->getOverrideQueue() === $queue->getId()) {
                    $isTarget = true;
                    break;
                }
            }
        }

        return $isTarget;
    }
}

1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\Helpers;
10
11			use Waca\DataObjects\EmailTemplate;
12			use Waca\DataObjects\RequestForm;
13			use Waca\DataObjects\RequestQueue;
14			use Waca\PdoDatabase;
15
16			class RequestQueueHelper
17			{
18			/**
19			* @param RequestQueue $queue
20			* @param bool $enabled
21			* @param bool $default
22			* @param bool $antiSpoof
23			* @param bool $titleBlacklist
24			*/
25			public function configureDefaults(
26			RequestQueue $queue,
27			bool $enabled,
28			bool $default,
29			bool $antiSpoof,
30			bool $titleBlacklist,
31			bool $isTarget
32			) {
33			// always allow enabling a queue
34			if ($enabled) {
35			$queue->setEnabled($enabled);
36			}
37
38			// only allow other enable-flag changes if we're not a default
39			if (!($queue->isDefault() \|\| $queue->isDefaultAntispoof() \|\| $queue->isDefaultTitleBlacklist() \|\| $isTarget)) {
40			$queue->setEnabled($enabled);
41			}
42
43			// only allow enabling the default flags, and only when we're enabled.
44			$queue->setDefault(($queue->isDefault() \|\| $default) && $queue->isEnabled());
45			$queue->setDefaultAntispoof(($queue->isDefaultAntispoof() \|\| $antiSpoof) && $queue->isEnabled());
46			$queue->setDefaultTitleBlacklist(($queue->isDefaultTitleBlacklist() \|\| $titleBlacklist) && $queue->isEnabled());
47			}
48
49			/**
50			* @param RequestQueue $queue
51			* @param PdoDatabase $database
52			*
53			* @return bool
54			*/
55			public function isEmailTemplateTarget(RequestQueue $queue, PdoDatabase $database): bool
56			{
57			$isTarget = false;
58			/** @var EmailTemplate[] $deferralTemplates */
59			$deferralTemplates = EmailTemplate::getAllActiveTemplates('defer', $database);
60			foreach ($deferralTemplates as $t) {
61			if ($t->getQueue() === $queue->getId()) {
62			$isTarget = true;
63			break;
64			}
65			}
66
67			return $isTarget;
68			}
69
70			public function isRequestFormTarget(RequestQueue $queue, PdoDatabase $database): bool
71			{
72			$isTarget = false;
73			$forms = RequestForm::getAllForms($database, 1); // FIXME: domains
74			foreach ($forms as $t) {
75			if ($t->isEnabled()) {
76			if ($t->getOverrideQueue() === $queue->getId()) {
77			$isTarget = true;
78			break;
79			}
80			}
81			}
82
83			return $isTarget;
84			}
85			}

stwalkerster / waca

Push — master ( 3e5dae...8d4e4c )

RequestQueueHelper::configureDefaults() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like