Issues (36)

app/Service/Test/TestService.php (3 issues)

1
<?php
2
/**
3
 * StupidlySimple - A PHP Framework For Lazy Developers.
4
 *
5
 * @author		Fariz Luqman <[email protected]>
6
 * @copyright	2017 Fariz Luqman
7
 * @license		MIT
8
 *
9
 * @link		https://stupidlysimple.github.io/
10
 */
11
12
namespace Service\Test;
13
14
use ServiceContainer;
0 ignored issues
show
The type ServiceContainer was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
15
16
class TestService extends ServiceContainer
17
{
18
    public function hello()
19
    {
20
        return 'Hello';
21
    }
22
23
    public function calculate($var1, $operation, $var2)
0 ignored issues
show
Comprehensibility introduced by
Avoid variables with short names like $var1. Configured minimum length is 5.

Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum.

Loading history...
Comprehensibility introduced by
Avoid variables with short names like $var2. Configured minimum length is 5.

Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum.

Loading history...
24
    {
25
        if ($operation == 'plus' || $operation == '+') {
26
            return $var1 + $var2;
27
        } elseif ($operation == 'minus' || $operation == '-') {
28
            return $var1 - $var2;
29
        } elseif ($operation == 'multiply' || $operation == '*') {
30
            return $var1 * $var2;
31
        } elseif ($operation == 'divide' || $operation == '/') {
32
            return $var1 / $var2;
33
        } else {
34
            return 'Invalid Operation';
35
        }
36
    }
37
38
    public function getRegisteredUsers()
39
    {
40
        return \Model\User::all();
41
    }
42
}
43