stupidlysimple / php

app/Controller/Auth.php

<?php
/**
 * StupidlySimple - A PHP Framework For Lazy Developers.
 *
 * @author		Fariz Luqman <fariz.fnb@gmail.com>
 * @copyright	2017 Fariz Luqman
 * @license		MIT
 *
 * @link		https://stupidlysimple.github.io/
 */

namespace Controller;

use Request;
use Response;
use Sentry;

The type Sentry was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Class Auth.
 */
class Auth
{
    private static $successRedirectURL = 'admin';

    public static function check()
    {
        if (Sentry::check() !== true) {
            Response::redirect('login');
        }
    }

    public static function authenticate()
    {
        try {
            // Login credentials
            $credentials = [
                'email'    => Request::get('email'),
                'password' => Request::get('password'),
            ];

            // Authenticate the user
            $user = Sentry::authenticate($credentials, false);

The assignment to $user is dead and can be removed.

Avoid variables with short names like $user. Configured minimum length is 5.

        } catch (\Cartalyst\Sentry\Users\LoginRequiredException $e) {
            Response::redirect('login')->with([
                'login_message'=> 'Login credentials not supplied',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\PasswordRequiredException $e) {
            Response::redirect('login')->with([
                'login_message'=> 'Password field is required',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\WrongPasswordException $e) {
            Response::redirect('login')->with([
                'login_message'=> 'Wrong password, try again.',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\UserNotFoundException $e) {
            Response::redirect('login')->with([
                'login_message'=> 'User not found.',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\UserNotActivatedException $e) {
            Response::redirect('login')->with([
                'login_message'=> 'User is not activated.',
                'type'         => 'alert-danger',
            ]);
        } finally {
            if (Sentry::check() === true) {
                Response::redirect(self::$successRedirectURL)->with([
                    'login_message'=> 'Login successful.',
                    'type'         => 'alert-success',
                ]);
            } else {
                Response::redirect('login')->with([
                    'login_message'=> 'Unable to login',
                    'type'         => 'alert-danger',
                ]);
            }
        }
    }

    public static function register()
    {
        try {
            $user = Sentry::register([

Avoid variables with short names like $user. Configured minimum length is 5.

                'email'      => Request::get('email'),
                'password'   => Request::get('password'),
                'first_name' => Request::get('first_name'),
                'last_name'  => Request::get('last_name'),
            ], $activate = true);
        } catch (\Cartalyst\Sentry\Users\LoginRequiredException $e) {
            Response::redirect('register')->with([
                'login_message'=> 'Login credentials not supplied',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\PasswordRequiredException $e) {
            Response::redirect('register')->with([
                'login_message'=> 'Password field is required',
                'type'         => 'alert-danger',
            ]);
        } catch (\Cartalyst\Sentry\Users\UserExistsException $e) {
            Response::redirect('register')->with([
                'login_message'=> 'User with that login already exist.',
                'type'         => 'alert-danger',
            ]);
        } catch (\Exception $e) {

Consider adding a comment why this CATCH block is empty.

        } finally {
            if ($user) {
                Response::redirect('login')->with([
                    'login_message'=> 'Registration successful. You can now login.',
                    'type'         => 'alert-success',
                ]);
            }
        }
    }

    public static function logout()
    {
        Sentry::logout();
        Response::redirect('login')->with([
            'login_message'=> 'Logout successful.',
            'type'         => 'alert-success',
        ]);
    }
}