Filter::box() - Code Metrics - Inspection of "improve additional filters support" - studiomado/query-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 2.2 (#120)

by Simone

created 2018-02-14 10:13 UTC

Filter::box() A

↳ Parent: Filter

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	11
cts	11
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1
crap	1

<?php

namespace Mado\QueryBundle\Objects;

class Filter
{
    private $rawFilter;

    private $ids;

    private $operator;

    public static function box(array $params)
    {
        $rawIds    = $params['ids'];
        $operator  = key($rawIds);
        $ids       = join(',', current($rawIds));
        $path      = $params['path'];
        $rawFilter = $path . '.id|' . $operator;

        return new self([
            'raw_filter' => $rawFilter,
            'ids'        => $ids,
            'operator'   => $operator,
            'path'       => $path,
        ]);
    }

    private function __construct(array $params)
    {
        $this->rawFilter = $params['raw_filter'];
        $this->ids       = $params['ids'];
        $this->operator  = $params['operator'];
        $this->path      = $params['path'];

    }

    public function getRawFilter()
    {
        return $this->rawFilter;
    }

    public function getIds()
    {
        return $this->ids;
    }

    public function getOperator()
    {
        return $this->operator;
    }

    public function getPath()
    {
        return $this->path;
    }
}


1		<?php
2
3		namespace Mado\QueryBundle\Objects;
4
5		class Filter
6		{
7		private $rawFilter;
8
9		private $ids;
10
11		private $operator;
12
13	6	public static function box(array $params)
14		{
15	6	$rawIds = $params['ids'];
16	6	$operator = key($rawIds);
17	6	$ids = join(',', current($rawIds));
18	6	$path = $params['path'];
19	6	$rawFilter = $path . '.id\|' . $operator;
20
21	6	return new self([
22	6	'raw_filter' => $rawFilter,
23	6	'ids' => $ids,
24	6	'operator' => $operator,
25	6	'path' => $path,
26		]);
27		}
28
29	6	private function __construct(array $params)
30		{
31	6	$this->rawFilter = $params['raw_filter'];
32	6	$this->ids = $params['ids'];
33	6	$this->operator = $params['operator'];
34	6	$this->path = $params['path'];
		0 ignored issues – show Bug Best Practice introduced 2018-02-09 10:12 UTC by Report Bug Copy Issue Report The property `path` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
35	6	}
36
37	4	public function getRawFilter()
38		{
39	4	return $this->rawFilter;
40		}
41
42	6	public function getIds()
43		{
44	6	return $this->ids;
45		}
46
47	6	public function getOperator()
48		{
49	6	return $this->operator;
50		}
51
52	1	public function getPath()
53		{
54	1	return $this->path;
55		}
56		}
57

studiomado / query-bundle

GitHub Access Token became invalid

Pull Request — 2.2 (#120)

Filter::box() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like