CurrentMetaData::extractFields() - Code Metrics - Inspection of "small refactoring to improve the readability of co..." - studiomado/query-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/2.2/provide_field_usab... ( 968349...01a28f )

by Simone

created 2018-06-27 00:41 UTC

CurrentMetaData::extractFields() A

↳ Parent: CurrentMetaData

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	7
ccs	5
cts	5
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace Mado\QueryBundle\Component\Sherlock;

use Doctrine\ORM\EntityManagerInterface;
use Mado\QueryBundle\Dictionary;

class CurrentMetaData
{
    private $metadata;

    private $manager;

    private $currentMetadata;

    private function __construct(EntityManagerInterface $manager)
    {
        $this->manager = $manager;

        $metadata = $this->manager
            ->getMetaDataFactory()
            ->getAllMetaData();

        $this->metadata = $metadata;
    }

    public static function fromEntityManager(EntityManagerInterface $manager) : CurrentMetaData
    {
        return new self($manager);
    }

    public function justEntitiesMetadata() : array
    {
        return array_map(function ($item) {
            return $item->rootEntityName;
        }, $this->metadata);
    }

    public function extractFields($entityClass) : array
    {
        $this->currentMetadata = $this->manager->getClassMetadata($entityClass);

        return array_map(function ($item) {
            return Dictionary::getOperatorsFromDoctrineType($item['type']);
        }, $this->currentMetadata->fieldMappings);

    }

    public function haveRelations() : bool
    {
        return isset(
            $this->currentMetadata->associationMappings['members']
        );
    }

    public function getCurrentTargetEntity() : string
    {
        return $this->currentMetadata->associationMappings
            ['members']
            ['targetEntity'];
    }
}


1		<?php
2
3		namespace Mado\QueryBundle\Component\Sherlock;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Mado\QueryBundle\Dictionary;
7
8		class CurrentMetaData
9		{
10		private $metadata;
11
12		private $manager;
13
14		private $currentMetadata;
15
16	1	private function __construct(EntityManagerInterface $manager)
17		{
18	1	$this->manager = $manager;
19
20	1	$metadata = $this->manager
21	1	->getMetaDataFactory()
22	1	->getAllMetaData();
23
24	1	$this->metadata = $metadata;
25	1	}
26
27	1	public static function fromEntityManager(EntityManagerInterface $manager) : CurrentMetaData
28		{
29	1	return new self($manager);
30		}
31
32		public function justEntitiesMetadata() : array
33		{
34	1	return array_map(function ($item) {
35	1	return $item->rootEntityName;
36	1	}, $this->metadata);
37		}
38
39	1	public function extractFields($entityClass) : array
40		{
41	1	$this->currentMetadata = $this->manager->getClassMetadata($entityClass);
42
43	1	return array_map(function ($item) {
44	1	return Dictionary::getOperatorsFromDoctrineType($item['type']);
45	1	}, $this->currentMetadata->fieldMappings);
		0 ignored issues – show Bug introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report Accessing `fieldMappings` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
46		}
47
48	1	public function haveRelations() : bool
49		{
50		return isset(
51	1	$this->currentMetadata->associationMappings['members']
52		);
53		}
54
55	1	public function getCurrentTargetEntity() : string
56		{
57	1	return $this->currentMetadata->associationMappings
58	1	['members']
59	1	['targetEntity'];
60		}
61		}
62

studiomado / query-bundle

GitHub Access Token became invalid

Push — feature/2.2/provide_field_usab... ( 968349...01a28f )

CurrentMetaData::extractFields() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like