Sherlock::getAll() - Code Metrics - Inspection of "fix typo" - studiomado/query-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/2.2/provide_field_usab... ( b3bc72...c2f535 )

by Simone

created 2018-06-27 15:18 UTC

Sherlock::getAll() A

↳ Parent: Sherlock

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	10
cts	10
cp	1
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	0
crap	3

<?php

namespace Mado\QueryBundle\Component\Sherlock;

use Doctrine\ORM\EntityManagerInterface;
use Mado\QueryBundle\Dictionary;
use Mado\QueryBundle\Services\StringParser;

class Sherlock
{
    private $currentMetadata;


    public function __construct(
        EntityManagerInterface $manager
    ) {
        $this->metadata = CurrentMetaData::fromEntityManager($manager);

    }

    public function getOpList($entityPath) : array
    {
        return $this->getAll()[$entityPath];
    }

    public function getAll() : array
    {
        $opList = [];

        foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
            $fields = $this->metadata->extractFields($entityClass);

            $entity = StringParser::dotNotationFor($entityClass);
            $opList[$entity]['fields'] = $fields;

            if ($this->metadata->hasRelations()) {
                $relations = $this->metadata->getRelations();
                $opList[$entity]['relations'][] = $relations;
            }
        }

        return $opList;
    }

    public function getRelations($entityPath) : array
    {
        return current($this->getOpList($entityPath)['relations']);
    }

    public function getFieldsType($entityPath) : array
    {
        $fieldTypes = [];

        foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
            $fields = $this->metadata->extractFieldsType($entityClass);

            $entity = StringParser::dotNotationFor($entityClass);
            $fieldTypes[$entity]['fields'] = $fields;
        }

        return $fieldTypes[$entityPath];
    }
}


1		<?php
2
3		namespace Mado\QueryBundle\Component\Sherlock;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Mado\QueryBundle\Dictionary;
7		use Mado\QueryBundle\Services\StringParser;
8
9		class Sherlock
10		{
11		private $currentMetadata;
		0 ignored issues – show introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report The private property `$currentMetadata` is not used, and could be removed. Loading history...
12
13	3	public function __construct(
14		EntityManagerInterface $manager
15		) {
16	3	$this->metadata = CurrentMetaData::fromEntityManager($manager);
		0 ignored issues – show Bug Best Practice introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report The property `metadata` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
17	3	}
18
19	2	public function getOpList($entityPath) : array
20		{
21	2	return $this->getAll()[$entityPath];
22		}
23
24	2	public function getAll() : array
25		{
26	2	$opList = [];
27
28	2	foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
29	2	$fields = $this->metadata->extractFields($entityClass);
30
31	2	$entity = StringParser::dotNotationFor($entityClass);
32	2	$opList[$entity]['fields'] = $fields;
33
34	2	if ($this->metadata->hasRelations()) {
35	2	$relations = $this->metadata->getRelations();
36	2	$opList[$entity]['relations'][] = $relations;
37		}
38		}
39
40	2	return $opList;
41		}
42
43	1	public function getRelations($entityPath) : array
44		{
45	1	return current($this->getOpList($entityPath)['relations']);
46		}
47
48	1	public function getFieldsType($entityPath) : array
49		{
50	1	$fieldTypes = [];
51
52	1	foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
53	1	$fields = $this->metadata->extractFieldsType($entityClass);
54
55	1	$entity = StringParser::dotNotationFor($entityClass);
56	1	$fieldTypes[$entity]['fields'] = $fields;
57		}
58
59	1	return $fieldTypes[$entityPath];
60		}
61		}
62

studiomado / query-bundle

GitHub Access Token became invalid

Push — feature/2.2/provide_field_usab... ( b3bc72...c2f535 )

Sherlock::getAll() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like