Sherlock::getRelations() - Code Metrics - Inspection of "small refactoring to improve the readability of co..." - studiomado/query-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/2.2/provide_field_usab... ( 03364e...b3bc72 )

by Simone

created 2018-06-27 08:07 UTC

Sherlock::getRelations() A

↳ Parent: Sherlock

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Mado\QueryBundle\Component\Sherlock;

use Doctrine\ORM\EntityManagerInterface;
use Mado\QueryBundle\Dictionary;
use Mado\QueryBundle\Services\StringParser;

class Sherlock
{
    private $currentMetadata;


    public function __construct(
        EntityManagerInterface $manager
    ) {
        $this->metadata = CurrentMetaData::fromEntityManager($manager);

    }

    public function getOpList($entityPath) : array
    {
        $opList = [];

        foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
            $fields = $this->metadata->extractFields($entityClass);

            $entity = StringParser::dotNotationFor($entityClass);
            $opList[$entity]['fields'] = $fields;

            if ($this->metadata->haveRelations()) {
                $relations = $this->metadata->getRelations();
                $opList[$entity]['relations'][] = $relations;
            }
        }

        return $opList[$entityPath];
    }

    public function getRelations($entityPath) : array
    {
        return current($this->getOpList($entityPath)['relations']);
    }
}


1		<?php
2
3		namespace Mado\QueryBundle\Component\Sherlock;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Mado\QueryBundle\Dictionary;
7		use Mado\QueryBundle\Services\StringParser;
8
9		class Sherlock
10		{
11		private $currentMetadata;
		0 ignored issues – show introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report The private property `$currentMetadata` is not used, and could be removed. Loading history...
12
13	2	public function __construct(
14		EntityManagerInterface $manager
15		) {
16	2	$this->metadata = CurrentMetaData::fromEntityManager($manager);
		0 ignored issues – show Bug Best Practice introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report The property `metadata` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
17	2	}
18
19	2	public function getOpList($entityPath) : array
20		{
21	2	$opList = [];
22
23	2	foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
24	2	$fields = $this->metadata->extractFields($entityClass);
25
26	2	$entity = StringParser::dotNotationFor($entityClass);
27	2	$opList[$entity]['fields'] = $fields;
28
29	2	if ($this->metadata->haveRelations()) {
30	2	$relations = $this->metadata->getRelations();
31	2	$opList[$entity]['relations'][] = $relations;
32		}
33		}
34
35	2	return $opList[$entityPath];
36		}
37
38	1	public function getRelations($entityPath) : array
39		{
40	1	return current($this->getOpList($entityPath)['relations']);
41		}
42		}
43

studiomado / query-bundle

GitHub Access Token became invalid

Push — feature/2.2/provide_field_usab... ( 03364e...b3bc72 )

Sherlock::getRelations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like