CurrentMetaData::getRelations() - Code Metrics - Inspection of "small refactoring to improve the readability of co..." - studiomado/query-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/2.2/provide_field_usab... ( 03364e...b3bc72 )

by Simone

created 2018-06-27 08:07 UTC

CurrentMetaData::getRelations() A

↳ Parent: CurrentMetaData

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php

namespace Mado\QueryBundle\Component\Sherlock;

use Doctrine\ORM\EntityManagerInterface;
use Mado\QueryBundle\Dictionary;
use Mado\QueryBundle\Services\StringParser;

class CurrentMetaData
{
    private $metadata;

    private $manager;

    private $currentMetadata;

    private function __construct(EntityManagerInterface $manager)
    {
        $this->manager = $manager;

        $metadata = $this->manager
            ->getMetaDataFactory()
            ->getAllMetaData();

        $this->metadata = $metadata;
    }

    public static function fromEntityManager(EntityManagerInterface $manager) : CurrentMetaData
    {
        return new self($manager);
    }

    public function justEntitiesMetadata() : array
    {
        return array_map(function ($item) {
            return $item->rootEntityName;
        }, $this->metadata);
    }

    public function extractFields($entityClass) : array
    {
        $this->currentMetadata = $this->manager->getClassMetadata($entityClass);

        return array_map(function ($item) {
            return Dictionary::getOperatorsFromDoctrineType($item['type']);
        }, $this->currentMetadata->fieldMappings);

    }

    public function haveRelations() : bool
    {
        return count($this->currentMetadata->associationMappings) > 0;
    }

    public function getRelations() : array
    {
        $relations = [];

        foreach ($this->currentMetadata->associationMappings as $rel) {
            $relations[
                $rel['inversedBy']
            ] = StringParser::dotNotationFor($rel['targetEntity']);
        }

        return $relations;
    }
}


1		<?php
2
3		namespace Mado\QueryBundle\Component\Sherlock;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Mado\QueryBundle\Dictionary;
7		use Mado\QueryBundle\Services\StringParser;
8
9		class CurrentMetaData
10		{
11		private $metadata;
12
13		private $manager;
14
15		private $currentMetadata;
16
17	2	private function __construct(EntityManagerInterface $manager)
18		{
19	2	$this->manager = $manager;
20
21	2	$metadata = $this->manager
22	2	->getMetaDataFactory()
23	2	->getAllMetaData();
24
25	2	$this->metadata = $metadata;
26	2	}
27
28	2	public static function fromEntityManager(EntityManagerInterface $manager) : CurrentMetaData
29		{
30	2	return new self($manager);
31		}
32
33		public function justEntitiesMetadata() : array
34		{
35	2	return array_map(function ($item) {
36	2	return $item->rootEntityName;
37	2	}, $this->metadata);
38		}
39
40	2	public function extractFields($entityClass) : array
41		{
42	2	$this->currentMetadata = $this->manager->getClassMetadata($entityClass);
43
44	2	return array_map(function ($item) {
45	2	return Dictionary::getOperatorsFromDoctrineType($item['type']);
46	2	}, $this->currentMetadata->fieldMappings);
		0 ignored issues – show Bug introduced 2018-06-27 00:32 UTC by Report Bug Copy Issue Report Accessing `fieldMappings` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
47		}
48
49	2	public function haveRelations() : bool
50		{
51	2	return count($this->currentMetadata->associationMappings) > 0;
52		}
53
54	2	public function getRelations() : array
55		{
56	2	$relations = [];
57
58	2	foreach ($this->currentMetadata->associationMappings as $rel) {
59		$relations[
60	2	$rel['inversedBy']
61	2	] = StringParser::dotNotationFor($rel['targetEntity']);
62		}
63
64	2	return $relations;
65		}
66		}
67

studiomado / query-bundle

GitHub Access Token became invalid

Push — feature/2.2/provide_field_usab... ( 03364e...b3bc72 )

CurrentMetaData::getRelations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like