Mado\QueryBundle\Queries\AbstractQuery

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

59.09%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getEntityName()	0	3	1
A	createQueryBuilder()	0	10	1
A	createSelectAndGroupBy()	0	13	1

<?php

namespace Mado\QueryBundle\Queries;

use Doctrine\ORM\EntityManager;
use Mado\QueryBundle\Services\StringParser;

class AbstractQuery
{
    protected $manager;

    protected $entityName;

    protected $entityAlias;

    protected $parser;

    public function __construct(EntityManager $manager)
    {
        $this->manager = $manager;
        $this->parser  = new StringParser();
    }

    public function createSelectAndGroupBy($entityName, $alias, $groupByField)
    {
        $select = $alias . '.' . $groupByField . ', count(' . $alias . '.id) as num';
        $groupBy = $alias . '.' . $groupByField . '';

        $this->entityName = $entityName;
        $this->entityAlias = $alias;

        $this->qBuilder = $this->manager->createQueryBuilder($this->entityName)

The property qBuilder does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

The call to Doctrine\ORM\EntityManager::createQueryBuilder() has too many arguments starting with $this->entityName.

            ->select($select)
            ->groupBy($groupBy);

        return $this;
    }

    public function createQueryBuilder($entityName, $alias)
    {
        $this->entityName = $entityName;
        $this->entityAlias = $alias;

        $this->qBuilder = $this->manager->createQueryBuilder($this->entityName)

The property qBuilder does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

The call to Doctrine\ORM\EntityManager::createQueryBuilder() has too many arguments starting with $this->entityName.

            ->select($alias)
            ->from($this->entityName, $alias);

        return $this;
    }

    public function getEntityName()
    {
        return $this->entityName;
    }
}