Mado\QueryBundle\Objects\Filter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	box()	0	13	1
A	getPath()	0	3	1
A	getRawFilter()	0	3	1
A	getOperator()	0	3	1
A	__construct()	0	6	1
A	getIds()	0	3	1

<?php

namespace Mado\QueryBundle\Objects;

class Filter
{
    private $rawFilter;

    private $ids;

    private $operator;

    public static function box(array $params)
    {
        $rawIds    = $params['ids'];
        $operator  = key($rawIds);
        $ids       = join(',', current($rawIds));
        $path      = $params['path'];
        $rawFilter = $path . '.id|' . $operator;

        return new self([
            'raw_filter' => $rawFilter,
            'ids'        => $ids,
            'operator'   => $operator,
            'path'       => $path,
        ]);
    }

    private function __construct(array $params)
    {
        $this->rawFilter = $params['raw_filter'];
        $this->ids       = $params['ids'];
        $this->operator  = $params['operator'];
        $this->path      = $params['path'];

The property path does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function getRawFilter()
    {
        return $this->rawFilter;
    }

    public function getIds()
    {
        return $this->ids;
    }

    public function getOperator()
    {
        return $this->operator;
    }

    public function getPath()
    {
        return $this->path;
    }
}