Mado\QueryBundle\Component\Sherlock\Sherlock

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getOpList()	0	17	3

<?php

namespace Mado\QueryBundle\Component\Sherlock;

use Doctrine\ORM\EntityManagerInterface;
use Mado\QueryBundle\Dictionary;
use Mado\QueryBundle\Services\StringParser;

class Sherlock
{
    private $currentMetadata;

The private property $currentMetadata is not used, and could be removed.

    public function __construct(
        EntityManagerInterface $manager
    ) {
        $this->metadata = CurrentMetaData::fromEntityManager($manager);

The property metadata does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function getOpList($entityPath) : array
    {
        $opList = [];

        foreach ($this->metadata->justEntitiesMetadata() as $entityClass) {
            $fields = $this->metadata->extractFields($entityClass);

            $entity = StringParser::dotNotationFor($entityClass);
            $opList[$entity]['fields'] = $fields;

            if ($this->metadata->haveRelations()) {
                $targetEntity = $this->metadata->getCurrentTargetEntity();
                $opList[$entity]['relations'] = [StringParser::dotNotationFor($targetEntity)];
            }
        }

        return $opList[$entityPath];
    }
}