studiomado /
query-bundle
| Conditions | 4 |
| Paths | 3 |
| Total Lines | 52 |
| Code Lines | 35 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 17 | public static function fromRequest(Request $request): FiltersOnHttpContext |
||
| 18 | { |
||
| 19 | $filters = new self(); |
||
| 20 | |||
| 21 | $id = $request->attributes->get('id'); |
||
| 22 | $route = $request->attributes->get('_route'); |
||
| 23 | $routeParams = $request->attributes->get('_route_params', []); |
||
| 24 | |||
| 25 | $rel = $request->query->get('rel', ''); |
||
| 26 | $select = $request->query->get('select', ''); |
||
| 27 | $printing = $request->query->get('printing', []); |
||
| 28 | |||
| 29 | $andFilters = $request->query->get('filtering', []); |
||
| 30 | $orFilters = $request->query->get('filtering_or', []); |
||
| 31 | $sorting = $request->query->get('sorting', []); |
||
| 32 | |||
| 33 | $page = $request->query->get('page', ''); |
||
| 34 | $limit = $request->query->get('limit', ''); |
||
| 35 | |||
| 36 | $filters->ensureFilterIsValid($printing); |
||
| 37 | $filters->ensureFilterIsValid($andFilters); |
||
| 38 | $filters->ensureFilterIsValid($orFilters); |
||
| 39 | $filters->ensureFilterIsValid($sorting); |
||
| 40 | |||
| 41 | // FIXME: what is it for? Can be removed? |
||
| 42 | $filterOrCorrected = []; |
||
| 43 | foreach ($orFilters as $key => $filterValue) { |
||
| 44 | if (is_array($filterValue)) { |
||
| 45 | foreach ($filterValue as $keyInternal => $internal) { |
||
| 46 | $filterOrCorrected[$keyInternal . '|' . $filters->getDiscriminator()] = $internal; |
||
| 47 | } |
||
| 48 | } else { |
||
| 49 | $filterOrCorrected[$key] = $filterValue; |
||
| 50 | } |
||
| 51 | } |
||
| 52 | |||
| 53 | $filters->setId($id); |
||
| 54 | $filters->setRoute($route); |
||
| 55 | $filters->setRouteParams($routeParams); |
||
| 56 | |||
| 57 | $filters->setRel($rel); |
||
| 58 | $filters->setSelect($select); |
||
| 59 | $filters->setPrinting($printing); |
||
| 60 | |||
| 61 | $filters->setAndFilters($andFilters); |
||
| 62 | $filters->setOrFilters($filterOrCorrected); |
||
| 63 | $filters->setSorting($sorting); |
||
| 64 | |||
| 65 | $filters->setPage($page); |
||
| 66 | $filters->setLimit($limit); |
||
| 67 | |||
| 68 | return $filters; |
||
| 69 | } |
||
| 89 |
