Strime\Slackify\Api\Oauth::access()

Complexity

Conditions	9
Paths	14

Size

Total Lines	45
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function access($client_id, $client_secret, $code, $redirect_uri = NULL) {

        // Check if the type of the variables is valid.
        if (!is_string($client_id)) {
            throw new InvalidArgumentException("The type of the client_id variable is not valid.");
        }
        if (!is_string($client_secret)) {
            throw new InvalidArgumentException("The type of the client_secret variable is not valid.");
        }
        if (!is_string($code)) {
            throw new InvalidArgumentException("The type of the code variable is not valid.");
        }
        if (($redirect_uri != NULL) && !is_string($redirect_uri)) {

It seems like you are loosely comparing $redirect_uri of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            throw new InvalidArgumentException("The type of the redirect_uri variable is not valid.");
        }

        // Set the arguments of the request
        $arguments = array(
            "client_id" => $client_id,
            "client_secret" => $client_secret,
            "code" => $code
        );

        if($redirect_uri != NULL) {

It seems like you are loosely comparing $redirect_uri of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $arguments["redirect_uri"] = $redirect_uri;
        }

        $this->setUrl("oauth.access", $arguments);

        // Send the request
        try {
            $client = new \GuzzleHttp\Client();
            $json_response = $client->request('GET', $this->getUrl(), []);
            $response = json_decode( $json_response->getBody() );
        }
        catch (RequestException $e) {
            throw new RuntimeException('The request to the API failed: '.$e->getMessage(), $e->getCode(), $e);
        }

        if($response->{'ok'} === FALSE) {
            throw new RuntimeException('The request to the API failed: '.$response->{'error'}.".");
        }

        return $json_response->getBody();
    }
}