Strime\Slackify\Api\Api::test()

Complexity

Conditions	9
Paths	22

Size

Total Lines	38
Code Lines	20

Duplication

Lines	38
Ratio	100 %

Importance

Changes	4
Bugs	0	Features	0

<?php
    public function test($error = NULL, $foo = NULL) {

This method seems to be duplicated in your project.

        // Check if the type of the variables is valid.
        if (($error != NULL) && !is_string($error)) {

It seems like you are loosely comparing $error of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            throw new InvalidArgumentException("The type of the error variable is not valid.");
        }
        if (($foo != NULL) && !is_string($foo)) {

It seems like you are loosely comparing $foo of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            throw new InvalidArgumentException("The type of the foo variable is not valid.");
        }

        // Set the arguments of the request
        $arguments = array();

        if($error != NULL) {

It seems like you are loosely comparing $error of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $arguments["error"] = $error;
        }
        if($foo != NULL) {

It seems like you are loosely comparing $foo of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $arguments["foo"] = $foo;
        }

        $this->setUrl("api.test", $arguments);

        // Send the request
        try {
            $client = new \GuzzleHttp\Client();
            $json_response = $client->request('GET', $this->getUrl(), []);
            $response = json_decode( $json_response->getBody() );
        }
        catch (RequestException $e) {
            throw new RuntimeException('The request to the API failed: '.$e->getMessage(), $e->getCode(), $e);
        }

        if($response->{'ok'} === FALSE) {
            throw new RuntimeException('The request to the API failed: '.$response->{'error'}.".");
        }

        return $this;
    }
}