ResponseObject::getJsonRpcVersion() - Code Metrics - Inspection of "Develop" - strider2038/json-rpc-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7)

by Igor

created 2020-03-14 17:49 UTC

ResponseObject::getJsonRpcVersion() A

↳ Parent: ResponseObject::__construct()

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php
/*
 * This file is part of JSON RPC Client.
 *
 * (c) Igor Lazarev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Strider2038\JsonRpcClient\Response;

/**
 * @author Igor Lazarev <[email protected]>
 */
class ResponseObject implements ResponseObjectInterface
{
    /** @var string */
    private $jsonrpc;

    /** @var mixed */
    private $result;

    /** @var ErrorObject|null */
    private $error;

    /** @var string|int|null */
    private $id;

    public function __construct(string $protocol, $result, $id)
    {
        $this->jsonrpc = $protocol;
        $this->result = $result;
        $this->id = $id;
    }

    public function getProtocol(): string
    {
        return $this->jsonrpc;
    }

    public function getId()
    {
        return $this->id;
    }

    public function getResult()
    {
        return $this->result;
    }

    public function hasError(): bool
    {
        return null !== $this->error;
    }

    public function getError(): ErrorObject
    {
        return $this->error;

    }

    public function setError(ErrorObject $error): void
    {
        $this->error = $error;
    }
}


1		<?php
2		/*
3		* This file is part of JSON RPC Client.
4		*
5		* (c) Igor Lazarev <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Strider2038\JsonRpcClient\Response;
12
13		/**
14		* @author Igor Lazarev <[email protected]>
15		*/
16		class ResponseObject implements ResponseObjectInterface
17		{
18		/** @var string */
19		private $jsonrpc;
20
21		/** @var mixed */
22		private $result;
23
24		/** @var ErrorObject\|null */
25		private $error;
26
27		/** @var string\|int\|null */
28		private $id;
29
30	47	public function __construct(string $protocol, $result, $id)
31		{
32	47	$this->jsonrpc = $protocol;
33	47	$this->result = $result;
34	47	$this->id = $id;
35	47	}
36
37	37	public function getProtocol(): string
38		{
39	37	return $this->jsonrpc;
40		}
41
42	21	public function getId()
43		{
44	21	return $this->id;
45		}
46
47	37	public function getResult()
48		{
49	37	return $this->result;
50		}
51
52	41	public function hasError(): bool
53		{
54	41	return null !== $this->error;
55		}
56
57	13	public function getError(): ErrorObject
58		{
59	13	return $this->error;
		0 ignored issues – show Bug Best Practice introduced 2020-03-14 17:53 UTC by Report Bug Copy Issue Report The expression `return $this->error` could return the type `null` which is incompatible with the type-hinted return `Strider2038\JsonRpcClient\Response\ErrorObject`. Consider adding an additional type-check to rule them out. Loading history...
60		}
61
62	13	public function setError(ErrorObject $error): void
63		{
64	13	$this->error = $error;
65	13	}
66		}
67

strider2038 / json-rpc-client

Pull Request — master (#7)

ResponseObject::getJsonRpcVersion() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like