RemoveChartsFromHttp2ServerPush::handle() - Code Metrics - Inspection of "add http/2 server push support for elixir assets" - strebl/pi.strebl.ch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Manuel

created 2017-02-18 00:30 UTC

RemoveChartsFromHttp2ServerPush::handle() A

↳ Parent: RemoveChartsFromHttp2ServerPush

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	7
nc	2
nop	2

<?php

namespace PiFinder\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

class RemoveChartsFromHttp2ServerPush
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $this->response = $next($request);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($this->shouldUseServerPush($request) && ! $request->is('stats')) {
            app('server-push')->resources = collect(app('server-push')->resources)->reject(function ($resource) {
                return str_contains($resource['path'], '/js/charts.');
            })->toArray();
        }

        return $this->response;
    }

    /**
     * @param Request $request
     *
     * @return bool
     */
    protected function shouldUseServerPush(Request $request) : bool
    {
        return ! $request->ajax();
    }
}


1			<?php
2
3			namespace PiFinder\Http\Middleware;
4
5			use Closure;
6			use Illuminate\Http\Request;
7
8			class RemoveChartsFromHttp2ServerPush
9			{
10			/**
11			* Handle an incoming request.
12			*
13			* @param \Illuminate\Http\Request $request
14			* @param \Closure $next
15			* @return mixed
16			*/
17			public function handle($request, Closure $next)
18			{
19			$this->response = $next($request);
			0 ignored issues – show Bug introduced 2017-02-18 00:38 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20
21			if ($this->shouldUseServerPush($request) && ! $request->is('stats')) {
22			app('server-push')->resources = collect(app('server-push')->resources)->reject(function ($resource) {
23			return str_contains($resource['path'], '/js/charts.');
24			})->toArray();
25			}
26
27			return $this->response;
28			}
29
30			/**
31			* @param Request $request
32			*
33			* @return bool
34			*/
35			protected function shouldUseServerPush(Request $request) : bool
36			{
37			return ! $request->ajax();
38			}
39			}
40

strebl / pi.strebl.ch

Pull Request — master (#18)

RemoveChartsFromHttp2ServerPush::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like