Storeman\Synchronization

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getRevision()	0	4	1
A	getTime()	0	4	1
A	getIdentity()	0	4	1
A	getIndex()	0	4	1
A	setIndex()	0	8	1
A	toScalarArray()	0	8	1
A	fromScalarArray()	0	11	1

<?php

namespace Storeman;

/**
 * As the name suggests this class represents the synchronization for a specific revision.
 */
class Synchronization
{
    /**
     * @var int
     */
    protected $revision;

    /**
     * @var \DateTime
     */
    protected $time;

    /**
     * @var string
     */
    protected $identity;

    /**
     * @var Index
     */
    protected $index;

    public function __construct(int $revision, \DateTime $time, string $identity, Index $index = null)
    {
        $this->revision = $revision;
        $this->time = $time;
        $this->identity = $identity;
        $this->index = $index;
    }

    public function getRevision(): int
    {
        return $this->revision;
    }

    public function getTime(): \DateTime
    {
        return $this->time;
    }

    public function getIdentity(): string
    {
        return $this->identity;
    }

    public function getIndex(): ?Index
    {
        return $this->index;
    }

    public function setIndex(Index $index): Synchronization
    {
        assert($this->index === null);

        $this->index = $index;

        return $this;
    }

    public function toScalarArray(): array
    {
        return [
            $this->revision,
            $this->time->getTimestamp(),
            $this->identity
        ];
    }

    public static function fromScalarArray(array $array, Index $index = null): Synchronization
    {
        $instance = new static(
            $array[0],
            \DateTime::createFromFormat('U', $array[1]),

It seems like \DateTime::createFromFormat('U', $array[1]) targeting DateTime::createFromFormat() can also be of type false; however, Storeman\Synchronization::__construct() does only seem to accept object<DateTime>, did you maybe forget to handle an error condition?

            $array[2],
            $index
        );

        return $instance;
    }
}