LaravelMobilpayController::validatePaymentDetails() - Code Metrics - Inspection of "!" - stl30/laravel-mobilpay - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — develop ( 2709f5...db8a67 )

by Stoea
created 2020-05-10 10:04 UTC
validatePaymentDetails() B

↳ Parent: LaravelMobilpayController
Complexity

Conditions	8
Paths	12
Size

Total Lines
Duplication

Lines	7
Ratio	10.77 %
Importance

Changes
Metric	Value
dl	7
loc	65
rs	7.5191
c	0
b	0
f	0
cc	8
nc	12
nop	1
How to fix Long Method

<?php

namespace Stl30\LaravelMobilpay\Http\Controllers;
use \Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Validator;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Request\Mobilpay_Payment_Request_Abstract;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Request\Mobilpay_Payment_Request_Card;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Invoice;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Mobilpay_Payment_Address;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Request\Mobilpay_Payment_Request_Notify;
use Stl30\LaravelMobilpay\Mobilpay\Payment\Mobilpay_Payment_Invoice;
use Stl30\LaravelMobilpay\MobilpayTransaction;

class LaravelMobilpayController extends Controller
{
    function getOrderId(){


        return uniqid(time().'-','');
    }
    function getOrderAmount(){


        return 111;
    }

    public function card()
    {
        //
        return view('vendor.laravel-mobilpay.card');
    }

    public function addTransaction(Mobilpay_Payment_Request_Card $mobilpayRequestObject)
    {
        $transaction = new MobilpayTransaction();
        $transaction-> id_transaction = $mobilpayRequestObject-> orderId;
        $transaction-> request_status = 0;
        $transaction-> value = $mobilpayRequestObject-> invoice -> amount;
        $transaction-> currency = $mobilpayRequestObject-> invoice -> currency;
        $transaction-> details = $mobilpayRequestObject-> invoice -> details;
        $transaction-> request_object = json_encode($mobilpayRequestObject,true);
        return $transaction -> save();
    }

    public function updateTransaction(Mobilpay_Payment_Request_Abstract $mobilpayReturnObject, $orderStatus='possible error')
    {
        $transaction = MobilpayTransaction::where('id_transaction','=',$mobilpayReturnObject -> orderId)->firstOrFail();
        $transaction-> value = $mobilpayReturnObject-> invoice -> amount;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transaction-> currency = $mobilpayReturnObject-> invoice -> currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transaction-> details = $mobilpayReturnObject-> invoice -> details;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transaction-> request_status = 1;
        $transaction-> status = $orderStatus;
        $transaction-> client_name = $mobilpayReturnObject-> objPmNotify -> customer-> firstName;
        $transaction-> client_surname = $mobilpayReturnObject-> objPmNotify -> customer-> lastName;
        $transaction-> client_address = $mobilpayReturnObject-> objPmNotify -> customer-> address;
        $transaction-> client_email = $mobilpayReturnObject-> objPmNotify -> customer-> email;
        $transaction-> client_phone = $mobilpayReturnObject-> objPmNotify -> customer-> mobilePhone;
        $transaction-> return_request_object = json_encode($mobilpayReturnObject,true);
        return $transaction-> update();
    }

    function addAutomatedTransactionError($errorCode,$errorType,$errorMessage,Mobilpay_Payment_Request_Abstract $mobilpayReturnObject) {

        $transaction = new MobilpayTransaction();
        $transaction-> id_transaction = 'error code:'.$errorCode.'>> error type:'.$errorType.'>> error message:'.$errorMessage;
        $transaction-> request_status = $errorType;
        $transaction-> request_object = json_encode($mobilpayReturnObject,true);
        $transaction-> status = $errorMessage;
        return $transaction -> save();
    }

    public static function validatePaymentDetails(array $parameters=[])
    {
        $errorsText = '';
        $paymentParameters = [];
        $requiredParameters = [
            #must haves values
            'payment_amount' => 'value of payment',
            'payment_details' => 'payment details placeholder',
            'order_id' => '',
            'billing_type' => 'person',//or company
        ];
        foreach ($requiredParameters as $requiredName => $value){
            if(isset($parameters[$requiredName]) && $parameters[$requiredName] !== null){

                $paymentParameters[$requiredName] = $parameters[$requiredName];
                continue;
            }
            $errorsText .= '<br>Missing required parameter '.$requiredName;
        }
        if(strlen($errorsText)){
            die($errorsText);
        }

        $optionalParameters = [
            #optional values
            'promotion_code' => '',
            #details on the cardholder address (optional)

            'billing_first_name' => '',//client first name
            'billing_last_name' => '',//client last name
            'billing_address' => '',//client adress
            'billing_email' => '',//client email
            'billing_mobile_phone' => '',//client phone/mobile
            'billing_fiscal_number' => '',
            'billing_identity_number' => '',
            'billing_country' => '',
            'billing_county' => '',
            'billing_city' => '',
            'billing_zip_code' => '',
            'billing_bank' => '',
            'billing_iban' => '',
            #details on the shipping address
            'shipping_type' => 'person',//or company
            'shipping_first_name' => '',
            'shipping_last_name' => '',
            'shipping_address' => '',
            'shipping_email' => '',
            'shipping_mobile_phone' => '',
            'shipping_fiscal_number' => '',
            'shipping_identity_number' => '',
            'shipping_country' => '',
            'shipping_county' => '',
            'shipping_city' => '',
            'shipping_zip_code' => '',
            'shipping_bank' => '',
            'shipping_iban' => '',
        ];

        foreach ($optionalParameters as $key => $Value) {
            if(isset($parameters[$key]) && $parameters[$key] !== null){

                $paymentParameters[$key]=$parameters[$key];
            }
        }

        return $paymentParameters;
    }

    public function cardRedirect(array $paymentParameters = array())
    {
        //DEBUG TO DELETE
        $paymentParameters['payment_amount'] = 111;
        $paymentParameters['payment_details'] = 'payment details';
        $paymentParameters['order_id'] = uniqid(time().'-','');
        $paymentParameters['billing_type'] = 'person';

        $paymentParameters = self::validatePaymentDetails($paymentParameters);


        #for testing purposes, all payment requests will be sent to the sandbox server. Once your account will be active you must switch back to the live server https://secure.mobilpay.ro
        #in order to display the payment form in a different language, simply add the language identifier to the end of the paymentUrl, i.e https://secure.mobilpay.ro/en for English
        if(config('laravel-mobilpay.sandbox_active')){
            $paymentUrl = config('laravel-mobilpay.sandbox_payment_link');
        }
        else{
            $paymentUrl = config('laravel-mobilpay.production_payment_link');
        }

        //$paymentUrl = 'https://secure.mobilpay.ro';
        // this is the path on your server to the public certificate. You may download this from Admin -> Conturi de comerciant -> Detalii -> Setari securitate
//        $x509FilePath 	= 'i.e: /home/certificates/public.cer';

        if(config('laravel-mobilpay.sandbox_active')){
            $x509FilePath 	= config('laravel-mobilpay.sandbox_public_key');
        }
        else{
            $x509FilePath 	= config('laravel-mobilpay.production_public_key');
        }

        try
        {
            srand((double) microtime() * 1000000);
            $objPmReqCard 						= new Mobilpay_Payment_Request_Card();
            #merchant account signature - generated by mobilpay.ro for every merchant account
            #semnatura contului de comerciant - mergi pe www.mobilpay.ro Admin -> Conturi de comerciant -> Detalii -> Setari securitate
            $objPmReqCard->signature 			= config('laravel-mobilpay.merchant_account_signature');
            #you should assign here the transaction ID registered by your application for this commercial operation
            #order_id should be unique for a merchant account
            $objPmReqCard->orderId 				= $paymentParameters['order_id'];
            #below is where mobilPay will send the payment result. This URL will always be called first; mandatory
            $objPmReqCard->confirmUrl 			= config('laravel-mobilpay.confirmUrl');
            #below is where mobilPay redirects the client once the payment process is finished. Not to be mistaken for a "successURL" nor "cancelURL"; mandatory
            $objPmReqCard->returnUrl 			= config('laravel-mobilpay.returnUrl');

            #detalii cu privire la plata: moneda, suma, descrierea
            #payment details: currency, amount, description
            $objPmReqCard->invoice = new Mobilpay_Payment_Invoice();
            #payment currency in ISO Code format; permitted values are RON, EUR, USD, MDL; please note that unless you have mobilPay permission to
            #process a currency different from RON, a currency exchange will occur from your currency to RON, using the official BNR exchange rate from that moment
            #and the customer will be presented with the payment amount in a dual currency in the payment page, i.e N.NN RON (e.ee EUR)
            $objPmReqCard->invoice->currency	= config('laravel-mobilpay.currency');
            $objPmReqCard->invoice->amount		= $paymentParameters['payment_amount'];
            #available installments number; if this parameter is present, only its value(s) will be available
            //$objPmReqCard->invoice->installments= '2,3';
            #selected installments number; its value should be within the available installments defined above
            //$objPmReqCard->invoice->selectedInstallments= '3';
            //platile ulterioare vor contine in request si informatiile despre token. Prima plata nu va contine linia de mai jos.
//            $objPmReqCard->invoice->tokenId = 'token_id';
            $objPmReqCard->invoice->details		= $paymentParameters['payment_details'];

            #detalii cu privire la adresa posesorului cardului
            #details on the cardholder address (optional)
            $billingAddress 				= new Mobilpay_Payment_Address();
            $billingAddress->type			= $paymentParameters['billing_type']; //should be "person"
            $billingAddress->firstName		= isset($paymentParameters['billing_first_name'])??$paymentParameters['billing_first_name'];
            $billingAddress->lastName		= isset($paymentParameters['billing_last_name'])??$paymentParameters['billing_last_name'];
            $billingAddress->address		= isset($paymentParameters['billing_address'])??$paymentParameters['billing_address'];
            $billingAddress->email			= isset($paymentParameters['billing_email'])??$paymentParameters['billing_email'];
            $billingAddress->mobilePhone	= isset($paymentParameters['billing_mobile_phone'])??$paymentParameters['billing_mobile_phone'];
            $objPmReqCard->invoice->setBillingAddress($billingAddress);

            #detalii cu privire la adresa de livrare
            #details on the shipping address
            $shippingAddress 				= new Mobilpay_Payment_Address();
            $shippingAddress->type			= isset($paymentParameters['shipping_type'])??$paymentParameters['shipping_type'];
            $shippingAddress->firstName		= isset($paymentParameters['shipping_first_name'])??$paymentParameters['shipping_first_name'];
            $shippingAddress->lastName		= isset($paymentParameters['shipping_last_name'])??$paymentParameters['shipping_last_name'];
            $shippingAddress->address		= isset($paymentParameters['shipping_address'])??$paymentParameters['shipping_address'];
            $shippingAddress->email		    = isset($paymentParameters['shipping_email'])??$paymentParameters['shipping_email'];
            $shippingAddress->mobilePhone	= isset($paymentParameters['shipping_mobile_phone'])??$paymentParameters['shipping_mobile_phone'];
            $objPmReqCard->invoice->setShippingAddress($shippingAddress);

            #uncomment the line below in order to see the content of the request
            // TODO for debug
//            dd(__METHOD__,$objPmReqCard,$objPmReqCard->signature,$objPmReqCard->orderId,get_class($objPmReqCard->invoice));
//            echo "<pre>";print_r($objPmReqCard);echo "</pre>";
            $objPmReqCard->encrypt($x509FilePath);
            $this ->addTransaction($objPmReqCard);
        }
        catch(\Exception $e)

        {

        }
        $exception = isset($e)?$e:null;
        //
        return view('vendor.laravel-mobilpay.cardRedirect')->with([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'objPmReqCard' => $objPmReqCard,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'e' => $exception,
            'paymentUrl' => $paymentUrl
        ]);
    }

    public function cardConfirm()
    {

        $errorCode 		= 0;
        $errorType		= Mobilpay_Payment_Request_Abstract::CONFIRM_ERROR_TYPE_NONE;
        $errorMessage	= '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $orderStatus    = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (strcasecmp($_SERVER['REQUEST_METHOD'], 'post') == 0)
        {
            if(isset($_POST['env_key']) && isset($_POST['data']))
            {
                #calea catre cheia privata
                #cheia privata este generata de mobilpay, accesibil in Admin -> Conturi de comerciant -> Detalii -> Setari securitate
                $privateKeyFilePath = config('laravel-mobilpay.sandbox_public_key');

                try
                {
                    $objPmReq = Mobilpay_Payment_Request_Abstract::factoryFromEncrypted($_POST['env_key'], $_POST['data'], $privateKeyFilePath);
                    #uncomment the line below in order to see the content of the request
                    //print_r($objPmReq);
                    $rrn = $objPmReq->objPmNotify->rrn;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    // action = status only if the associated error code is zero
                    if ($objPmReq->objPmNotify->errorCode == 0) {
                        switch($objPmReq->objPmNotify->action)
                        {
                            #orice action este insotit de un cod de eroare si de un mesaj de eroare. Acestea pot fi citite folosind $cod_eroare = $objPmReq->objPmNotify->errorCode; respectiv $mesaj_eroare = $objPmReq->objPmNotify->errorMessage;
                            #pentru a identifica ID-ul comenzii pentru care primim rezultatul platii folosim $id_comanda = $objPmReq->orderId;
                            case 'confirmed':
                                #cand action este confirmed avem certitudinea ca banii au plecat din contul posesorului de card si facem update al starii comenzii si livrarea produsului
                                //update DB, SET status = "confirmed/captured"
                                $orderStatus = 'confirmed/captured';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            case 'confirmed_pending':
                                #cand action este confirmed_pending inseamna ca tranzactia este in curs de verificare antifrauda. Nu facem livrare/expediere. In urma trecerii de aceasta verificare se va primi o noua notificare pentru o actiune de confirmare sau anulare.
                                //update DB, SET status = "pending"
                                $orderStatus = 'pending';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            case 'paid_pending':
                                #cand action este paid_pending inseamna ca tranzactia este in curs de verificare. Nu facem livrare/expediere. In urma trecerii de aceasta verificare se va primi o noua notificare pentru o actiune de confirmare sau anulare.
                                //update DB, SET status = "pending"
                                $orderStatus = 'pending';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            case 'paid':
                                #cand action este paid inseamna ca tranzactia este in curs de procesare. Nu facem livrare/expediere. In urma trecerii de aceasta procesare se va primi o noua notificare pentru o actiune de confirmare sau anulare.
                                //update DB, SET status = "open/preauthorized"
                                $orderStatus = 'open/preauthorized';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            case 'canceled':
                                #cand action este canceled inseamna ca tranzactia este anulata. Nu facem livrare/expediere.
                                //update DB, SET status = "canceled"
                                $orderStatus = 'canceled';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            case 'credit':
                                #cand action este credit inseamna ca banii sunt returnati posesorului de card. Daca s-a facut deja livrare, aceasta trebuie oprita sau facut un reverse.
                                //update DB, SET status = "refunded"
                                $orderStatus = 'refunded';
                                $errorMessage = $objPmReq->objPmNotify->errorMessage;
                                break;
                            default:
                                $errorType		= Mobilpay_Payment_Request_Abstract::CONFIRM_ERROR_TYPE_PERMANENT;
                                $errorCode 		= Mobilpay_Payment_Request_Abstract::ERROR_CONFIRM_INVALID_ACTION;
                                $orderStatus = $errorMessage 	= 'mobilpay_refference_action paramaters is invalid';
                                break;
                        }
                    }
                    else {
                        //update DB, SET status = "rejected"
                        $orderStatus = 'rejected';
                        $errorMessage = $objPmReq->objPmNotify->errorMessage;
                    }
                }
                catch(Exception $e)
                {
                    $errorType 		= Mobilpay_Payment_Request_Abstract::CONFIRM_ERROR_TYPE_TEMPORARY;
                    $errorCode		= $e->getCode();
                    $orderStatus = $errorMessage = $e->getMessage();
                }
            }
            else
            {
                $errorType 		= Mobilpay_Payment_Request_Abstract::CONFIRM_ERROR_TYPE_PERMANENT;
                $errorCode		= Mobilpay_Payment_Request_Abstract::ERROR_CONFIRM_INVALID_POST_PARAMETERS;
                $orderStatus = $errorMessage 	= 'mobilpay.ro posted invalid parameters';
            }
        }
        else
        {
            $errorType 		= Mobilpay_Payment_Request_Abstract::CONFIRM_ERROR_TYPE_PERMANENT;
            $errorCode		= Mobilpay_Payment_Request_Abstract::ERROR_CONFIRM_INVALID_POST_METHOD;
            $orderStatus = $errorMessage 	= 'invalid request metod for payment confirmation';
        }


        if($errorCode == 0)
        {
            if($this -> updateTransaction($objPmReq,$orderStatus) !== true){
                Log::debug('Could not update transaction <<>> '.json_encode($objPmReq,true).' <<<>>> with orderStatus:'.$orderStatus);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
            else{
                Log::debug('Update transaction success <<>> '.json_encode($objPmReq,true).' <<<>>> with orderStatus:'.$orderStatus);
            }
            Log::debug('No errors');
            Log::debug(json_encode($errorMessage,true));
        }
        else
        {
            $objPmReq = (isset($objPmReq) && is_object($objPmReq))?$objPmReq:'';
            if($this -> addAutomatedTransactionError($errorCode,$errorType,$errorMessage,$objPmReq) !== true){
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                Log::debug('Could not addAutomatedTransactionError <<>> errortype:'.$errorType.'<<<>>> error code:'.$errorCode.'<<<<>>>'.json_encode($errorMessage,true));
            }
            else{
                Log::debug('addedAutomatedTransactionError <<>> errortype:'.$errorType.'<<<>>> error code:'.$errorCode.'<<<<>>>'.json_encode($errorMessage,true));
            }
            Log::debug('With errors');
            Log::debug('errortype:'.$errorType.'<<<>>> error code:'.$errorCode.'<<<<>>>'.json_encode($errorMessage,true));
        }
        return;
    }

    public function cardReturn(Request $request)
    {

        $orderStatus = 'eroare';
        $orderId = (isset($request -> orderId) && $request -> orderId !== null)?$request -> orderId:'';
        $order = MobilpayTransaction::with('id_transaction','=',$request -> orderId)->first();
        if($order !== null){

            switch ($order->status){
                case 'confirmed/captured':
                    $orderStatus = 'succes';
                    break;
                case 'rejected':
                    $orderStatus = 'rejected';
                    break;
                case 'pending':
                    $orderStatus = 'pending';
                    break;
                default:
                    $orderStatus = 'please contact us';
                    break;
            }


        }

        return view('vendor.laravel-mobilpay.cardReturn')->with([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'orderId' => $orderId,
            'orderStatus' => $orderStatus
        ]);

    }
}

Push — develop ( 2709f5...db8a67 )

validatePaymentDetails() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

stl30 / laravel-mobilpay

Push — develop ( 2709f5...db8a67 )

validatePaymentDetails() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
