PartnersEventBlockService::configureSettings() - Code Metrics - Inspection of "Merge pull request #482 from metalslave/up-sonata-..." - stfalcon/fwdays - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 227e03...1b465c )

by Artem

created 2019-04-03 12:25 UTC

PartnersEventBlockService::configureSettings() A

↳ Parent: PartnersEventBlockService

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace Application\Bundle\DefaultBundle\Service\EventBlock;

use Doctrine\Common\Persistence\ObjectRepository;
use Sonata\BlockBundle\Block\Service\AbstractBlockService;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Stfalcon\Bundle\EventBundle\Entity\Event;
use Stfalcon\Bundle\SponsorBundle\Repository\CategoryRepository;
use Stfalcon\Bundle\SponsorBundle\Repository\SponsorRepository;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Class PartnersEventBlockService.
 */
class PartnersEventBlockService extends AbstractBlockService
{
    /** @var SponsorRepository */
    private $partnerRepository;

    /** @var CategoryRepository */
    private $partnerCategoryRepository;

    /**
     * PartnersEventBlockService constructor.
     *
     * @param string           $name
     * @param EngineInterface  $templating
     * @param ObjectRepository $partnerRepository
     * @param ObjectRepository $partnerCategoryRepository
     */
    public function __construct($name, EngineInterface $templating, ObjectRepository $partnerRepository, ObjectRepository $partnerCategoryRepository)
    {
        parent::__construct($name, $templating);

        $this->partnerRepository = $partnerRepository;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->partnerCategoryRepository = $partnerCategoryRepository;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * {@inheritdoc}
     */
    public function execute(BlockContextInterface $blockContext, Response $response = null)
    {
        $event = $blockContext->getSetting('event');

        if (!$event instanceof Event) {
            return new NotFoundHttpException();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $partners = $this->partnerRepository->getSponsorsOfEventWithCategory($event);

        $sortedPartners = [];
        foreach ($partners as $key => $partner) {
            $partnerCategory = $this->partnerCategoryRepository->find($partner['id']);
            if ($partnerCategory) {
                $sortedPartners[$partnerCategory->isWideContainer()][$partnerCategory->getSortOrder()][$partnerCategory->getName()][] = $partner[0];
            }
        }

        if (isset($sortedPartners[0])) {
            krsort($sortedPartners[0]);
        }

        if (isset($sortedPartners[1])) {
            krsort($sortedPartners[1]);
        }

        return $this->renderResponse($blockContext->getTemplate(), [
            'block' => $blockContext->getBlock(),
            'settings' => $blockContext->getSettings(),
            'partners' => $sortedPartners,
        ], $response);
    }

    /**
     * {@inheritdoc}
     */
    public function configureSettings(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'template' => 'ApplicationDefaultBundle:Redesign/Partner:partners.html.twig',
            'event' => null,
            'event_block' => null,
        ]);
    }
}


1			<?php
2
3			namespace Application\Bundle\DefaultBundle\Service\EventBlock;
4
5			use Doctrine\Common\Persistence\ObjectRepository;
6			use Sonata\BlockBundle\Block\Service\AbstractBlockService;
7			use Sonata\BlockBundle\Block\BlockContextInterface;
8			use Stfalcon\Bundle\EventBundle\Entity\Event;
9			use Stfalcon\Bundle\SponsorBundle\Repository\CategoryRepository;
10			use Stfalcon\Bundle\SponsorBundle\Repository\SponsorRepository;
11			use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
12			use Symfony\Component\HttpFoundation\Response;
13			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
14			use Symfony\Component\OptionsResolver\OptionsResolver;
15
16			/**
17			* Class PartnersEventBlockService.
18			*/
19			class PartnersEventBlockService extends AbstractBlockService
20			{
21			/** @var SponsorRepository */
22			private $partnerRepository;
23
24			/** @var CategoryRepository */
25			private $partnerCategoryRepository;
26
27			/**
28			* PartnersEventBlockService constructor.
29			*
30			* @param string $name
31			* @param EngineInterface $templating
32			* @param ObjectRepository $partnerRepository
33			* @param ObjectRepository $partnerCategoryRepository
34			*/
35			public function __construct($name, EngineInterface $templating, ObjectRepository $partnerRepository, ObjectRepository $partnerCategoryRepository)
36			{
37			parent::__construct($name, $templating);
38
39			$this->partnerRepository = $partnerRepository;
			0 ignored issues – show Documentation Bug introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report `$partnerRepository` is of type `Doctrine\Common\Persistence\ObjectRepository`, but the property `$partnerRepository` was declared to be of type `Stfalcon\Bundle\SponsorB...itory\SponsorRepository`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
40			$this->partnerCategoryRepository = $partnerCategoryRepository;
			0 ignored issues – show Documentation Bug introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report `$partnerCategoryRepository` is of type `Doctrine\Common\Persistence\ObjectRepository`, but the property `$partnerCategoryRepository` was declared to be of type `Stfalcon\Bundle\SponsorB...tory\CategoryRepository`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function execute(BlockContextInterface $blockContext, Response $response = null)
47			{
48			$event = $blockContext->getSetting('event');
49
50			if (!$event instanceof Event) {
51			return new NotFoundHttpException();
			0 ignored issues – show Bug Best Practice introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report The expression `return new Symfony\Compo...NotFoundHttpException()` returns the type `Symfony\Component\HttpKe...n\NotFoundHttpException` which is incompatible with the return type mandated by `Sonata\BlockBundle\Block...iceInterface::execute()` of `Symfony\Component\HttpFoundation\Response`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
52			}
53
54			$partners = $this->partnerRepository->getSponsorsOfEventWithCategory($event);
55
56			$sortedPartners = [];
57			foreach ($partners as $key => $partner) {
58			$partnerCategory = $this->partnerCategoryRepository->find($partner['id']);
59			if ($partnerCategory) {
60			$sortedPartners[$partnerCategory->isWideContainer()][$partnerCategory->getSortOrder()][$partnerCategory->getName()][] = $partner[0];
61			}
62			}
63
64			if (isset($sortedPartners[0])) {
65			krsort($sortedPartners[0]);
66			}
67
68			if (isset($sortedPartners[1])) {
69			krsort($sortedPartners[1]);
70			}
71
72			return $this->renderResponse($blockContext->getTemplate(), [
73			'block' => $blockContext->getBlock(),
74			'settings' => $blockContext->getSettings(),
75			'partners' => $sortedPartners,
76			], $response);
77			}
78
79			/**
80			* {@inheritdoc}
81			*/
82			public function configureSettings(OptionsResolver $resolver)
83			{
84			$resolver->setDefaults([
85			'template' => 'ApplicationDefaultBundle:Redesign/Partner:partners.html.twig',
86			'event' => null,
87			'event_block' => null,
88			]);
89			}
90			}
91

stfalcon / fwdays

Push — master ( 227e03...1b465c )

PartnersEventBlockService::configureSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like