TicketStatusEventBlockService::setDefaultSettings() - Code Metrics - Inspection of "Update sonata admin bundle to v3" - stfalcon/fwdays - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#482)

by Andrew

created 2019-04-03 12:21 UTC

setDefaultSettings() A

↳ Parent: TicketStatusEventBlockService

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Application\Bundle\DefaultBundle\Service\EventBlock;

use Application\Bundle\DefaultBundle\Service\TicketService;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Sonata\BlockBundle\Block\Service\AbstractBlockService;
use Stfalcon\Bundle\EventBundle\Entity\Event;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Class TicketStatusEventBlockService.
 */
class TicketStatusEventBlockService extends AbstractBlockService
{
    /** @var TicketService */
    private $ticketService;

    /**
     * TicketStatusEventBlockService constructor.
     *
     * @param string          $name
     * @param EngineInterface $templating
     * @param TicketService   $ticketService
     */
    public function __construct($name, EngineInterface $templating, TicketService $ticketService)
    {
        parent::__construct($name, $templating);

        $this->ticketService = $ticketService;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(BlockContextInterface $blockContext, Response $response = null)
    {
        $event = $blockContext->getSetting('event');

        if (!$event instanceof Event) {
            return new NotFoundHttpException();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $position = $blockContext->getSetting('position');
        $ticketCost = $blockContext->getSetting('ticket_cost');

        $result = $this->ticketService->getTicketHtmlData(
            $event,
            $position,
            $ticketCost
        );

        return $this->renderResponse($blockContext->getTemplate(), [
            'block' => $blockContext->getBlock(),
            'event' => $event,
            'result' => $result,
        ], $response);
    }

    /**
     * {@inheritdoc}
     */
    public function configureSettings(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'template' => 'ApplicationDefaultBundle:Redesign/Event:event.ticket.status.html.twig',
            'event' => null,
            'position' => 'price_block',
            'ticket_cost' => null,
            'event_block' => null,
        ]);
    }
}


1			<?php
2
3			namespace Application\Bundle\DefaultBundle\Service\EventBlock;
4
5			use Application\Bundle\DefaultBundle\Service\TicketService;
6			use Sonata\BlockBundle\Block\BlockContextInterface;
7			use Sonata\BlockBundle\Block\Service\AbstractBlockService;
8			use Stfalcon\Bundle\EventBundle\Entity\Event;
9			use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
10			use Symfony\Component\HttpFoundation\Response;
11			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
12			use Symfony\Component\OptionsResolver\OptionsResolver;
13
14			/**
15			* Class TicketStatusEventBlockService.
16			*/
17			class TicketStatusEventBlockService extends AbstractBlockService
18			{
19			/** @var TicketService */
20			private $ticketService;
21
22			/**
23			* TicketStatusEventBlockService constructor.
24			*
25			* @param string $name
26			* @param EngineInterface $templating
27			* @param TicketService $ticketService
28			*/
29			public function __construct($name, EngineInterface $templating, TicketService $ticketService)
30			{
31			parent::__construct($name, $templating);
32
33			$this->ticketService = $ticketService;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function execute(BlockContextInterface $blockContext, Response $response = null)
40			{
41			$event = $blockContext->getSetting('event');
42
43			if (!$event instanceof Event) {
44			return new NotFoundHttpException();
			0 ignored issues – show Bug Best Practice introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report The expression `return new Symfony\Compo...NotFoundHttpException()` returns the type `Symfony\Component\HttpKe...n\NotFoundHttpException` which is incompatible with the return type mandated by `Sonata\BlockBundle\Block...iceInterface::execute()` of `Symfony\Component\HttpFoundation\Response`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
45			}
46
47			$position = $blockContext->getSetting('position');
48			$ticketCost = $blockContext->getSetting('ticket_cost');
49
50			$result = $this->ticketService->getTicketHtmlData(
51			$event,
52			$position,
53			$ticketCost
54			);
55
56			return $this->renderResponse($blockContext->getTemplate(), [
57			'block' => $blockContext->getBlock(),
58			'event' => $event,
59			'result' => $result,
60			], $response);
61			}
62
63			/**
64			* {@inheritdoc}
65			*/
66			public function configureSettings(OptionsResolver $resolver)
67			{
68			$resolver->setDefaults([
69			'template' => 'ApplicationDefaultBundle:Redesign/Event:event.ticket.status.html.twig',
70			'event' => null,
71			'position' => 'price_block',
72			'ticket_cost' => null,
73			'event_block' => null,
74			]);
75			}
76			}
77

stfalcon / fwdays

Pull Request — master (#482)

setDefaultSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like