SpeakersEventBlockService::configureSettings() - Code Metrics - Inspection of "Update sonata admin bundle to v3" - stfalcon/fwdays - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#482)

by Andrew

created 2019-04-03 12:21 UTC

SpeakersEventBlockService::configureSettings() A

↳ Parent: SpeakersEventBlockService

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace Application\Bundle\DefaultBundle\Service\EventBlock;

use Doctrine\Common\Persistence\ObjectRepository;
use Sonata\BlockBundle\Block\Service\AbstractBlockService;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Stfalcon\Bundle\EventBundle\Entity\Event;
use Stfalcon\Bundle\EventBundle\Repository\ReviewRepository;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Translation\IdentityTranslator;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * Class SpeakersEventBlockService.
 */
class SpeakersEventBlockService extends AbstractBlockService
{
    /** @var IdentityTranslator */
    private $translator;

    /** @var ReviewRepository */
    private $reviewRepository;

    /**
     * SpeakersEventBlockService constructor.
     *
     * @param string              $name
     * @param EngineInterface     $templating
     * @param TranslatorInterface $translator
     * @param ObjectRepository    $reviewRepository
     */
    public function __construct($name, EngineInterface $templating, TranslatorInterface $translator, ObjectRepository $reviewRepository)
    {
        parent::__construct($name, $templating);

        $this->translator = $translator;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->reviewRepository = $reviewRepository;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * {@inheritdoc}
     */
    public function execute(BlockContextInterface $blockContext, Response $response = null)
    {
        $event = $blockContext->getSetting('event');

        if (!$event instanceof Event) {
            return new NotFoundHttpException();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $speakers = $event->getSpeakers();

        /** @var $speaker \Stfalcon\Bundle\EventBundle\Entity\Speaker */
        foreach ($speakers as &$speaker) {
            $speaker->setReviews(
                $this->reviewRepository->findReviewsOfSpeakerForEvent($speaker, $event)
            );
        }

        return $this->renderResponse($blockContext->getTemplate(), [
            'block' => $blockContext->getBlock(),
            'templateTitle' => $this->translator->trans('speaker.title'),
            'speakers' => $speakers,
            'section_id' => 'speakers-event',
            'with_review' => true,
            'event' => $event,
        ], $response);
    }

    /**
     * {@inheritdoc}
     */
    public function configureSettings(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'template' => 'ApplicationDefaultBundle:Redesign/Event:event.speakers.html.twig',
            'event' => null,
            'event_block' => null,
        ]);
    }
}


1			<?php
2
3			namespace Application\Bundle\DefaultBundle\Service\EventBlock;
4
5			use Doctrine\Common\Persistence\ObjectRepository;
6			use Sonata\BlockBundle\Block\Service\AbstractBlockService;
7			use Sonata\BlockBundle\Block\BlockContextInterface;
8			use Stfalcon\Bundle\EventBundle\Entity\Event;
9			use Stfalcon\Bundle\EventBundle\Repository\ReviewRepository;
10			use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
11			use Symfony\Component\HttpFoundation\Response;
12			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13			use Symfony\Component\OptionsResolver\OptionsResolver;
14			use Symfony\Component\Translation\IdentityTranslator;
15			use Symfony\Component\Translation\TranslatorInterface;
16
17			/**
18			* Class SpeakersEventBlockService.
19			*/
20			class SpeakersEventBlockService extends AbstractBlockService
21			{
22			/** @var IdentityTranslator */
23			private $translator;
24
25			/** @var ReviewRepository */
26			private $reviewRepository;
27
28			/**
29			* SpeakersEventBlockService constructor.
30			*
31			* @param string $name
32			* @param EngineInterface $templating
33			* @param TranslatorInterface $translator
34			* @param ObjectRepository $reviewRepository
35			*/
36			public function __construct($name, EngineInterface $templating, TranslatorInterface $translator, ObjectRepository $reviewRepository)
37			{
38			parent::__construct($name, $templating);
39
40			$this->translator = $translator;
			0 ignored issues – show Documentation Bug introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report `$translator` is of type `Symfony\Component\Translation\TranslatorInterface`, but the property `$translator` was declared to be of type `Symfony\Component\Translation\IdentityTranslator`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
41			$this->reviewRepository = $reviewRepository;
			0 ignored issues – show Documentation Bug introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report `$reviewRepository` is of type `Doctrine\Common\Persistence\ObjectRepository`, but the property `$reviewRepository` was declared to be of type `Stfalcon\Bundle\EventBun...sitory\ReviewRepository`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
42			}
43
44			/**
45			* {@inheritdoc}
46			*/
47			public function execute(BlockContextInterface $blockContext, Response $response = null)
48			{
49			$event = $blockContext->getSetting('event');
50
51			if (!$event instanceof Event) {
52			return new NotFoundHttpException();
			0 ignored issues – show Bug Best Practice introduced 2019-03-19 13:08 UTC by Report Bug Copy Issue Report The expression `return new Symfony\Compo...NotFoundHttpException()` returns the type `Symfony\Component\HttpKe...n\NotFoundHttpException` which is incompatible with the return type mandated by `Sonata\BlockBundle\Block...iceInterface::execute()` of `Symfony\Component\HttpFoundation\Response`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
53			}
54
55			$speakers = $event->getSpeakers();
56
57			/** @var $speaker \Stfalcon\Bundle\EventBundle\Entity\Speaker */
58			foreach ($speakers as &$speaker) {
59			$speaker->setReviews(
60			$this->reviewRepository->findReviewsOfSpeakerForEvent($speaker, $event)
61			);
62			}
63
64			return $this->renderResponse($blockContext->getTemplate(), [
65			'block' => $blockContext->getBlock(),
66			'templateTitle' => $this->translator->trans('speaker.title'),
67			'speakers' => $speakers,
68			'section_id' => 'speakers-event',
69			'with_review' => true,
70			'event' => $event,
71			], $response);
72			}
73
74			/**
75			* {@inheritdoc}
76			*/
77			public function configureSettings(OptionsResolver $resolver)
78			{
79			$resolver->setDefaults([
80			'template' => 'ApplicationDefaultBundle:Redesign/Event:event.speakers.html.twig',
81			'event' => null,
82			'event_block' => null,
83			]);
84			}
85			}
86

stfalcon / fwdays

Pull Request — master (#482)

SpeakersEventBlockService::configureSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like