Application\Bundle\DefaultBundle\Service\EventBlock\CandidateSpeakersEventBlockService

Complexity

Total Complexity

5

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	25	3
A	__construct()	0	6	1
A	configureSettings()	0	6	1

<?php

namespace Application\Bundle\DefaultBundle\Service\EventBlock;

use Doctrine\Common\Persistence\ObjectRepository;
use Sonata\BlockBundle\Block\BlockContextInterface;
use Sonata\BlockBundle\Block\Service\AbstractBlockService;
use Stfalcon\Bundle\EventBundle\Entity\Event;
use Stfalcon\Bundle\EventBundle\Repository\ReviewRepository;
use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Translation\IdentityTranslator;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * Class CandidateSpeakersEventBlockService.
 */
class CandidateSpeakersEventBlockService extends AbstractBlockService
{
    /** @var IdentityTranslator */
    private $translator;

    /** @var ReviewRepository */
    private $reviewRepository;

    /**
     * SpeakersEventBlockService constructor.
     *
     * @param string              $name
     * @param EngineInterface     $templating
     * @param TranslatorInterface $translator
     * @param ObjectRepository    $reviewRepository
     */
    public function __construct($name, EngineInterface $templating, TranslatorInterface $translator, ObjectRepository $reviewRepository)
    {
        parent::__construct($name, $templating);

        $this->translator = $translator;

$translator is of type Symfony\Component\Translation\TranslatorInterface, but the property $translator was declared to be of type Symfony\Component\Translation\IdentityTranslator. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->reviewRepository = $reviewRepository;

$reviewRepository is of type Doctrine\Common\Persistence\ObjectRepository, but the property $reviewRepository was declared to be of type Stfalcon\Bundle\EventBundle\Repository\ReviewRepository. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * {@inheritdoc}
     */
    public function execute(BlockContextInterface $blockContext, Response $response = null)
    {
        $event = $blockContext->getSetting('event');

        if (!$event instanceof Event) {
            return new NotFoundHttpException();

The expression return new Symfony\Component\HttpKernel\Exception\NotFoundHttpException() returns the type Symfony\Component\HttpKernel\Exception\NotFoundHttpException which is incompatible with the return type mandated by Sonata\BlockBundle\Block\BlockServiceInterface::execute() of Symfony\Component\HttpFoundation\Response.

        }

        $speakers = $event->getCandidateSpeakers();

        /** @var $speaker \Stfalcon\Bundle\EventBundle\Entity\Speaker */
        foreach ($speakers as &$speaker) {
            $speaker->setReviews(
                $this->reviewRepository->findReviewsOfSpeakerForEvent($speaker, $event)
            );
        }

        return $this->renderResponse($blockContext->getTemplate(), [
            'block' => $blockContext->getBlock(),
            'templateTitle' => $this->translator->trans('candidate.speaker.title'),
            'speakers' => $speakers,
            'section_id' => 'candidate-speakers-event',
            'with_review' => true,
            'event' => $event,
        ], $response);
    }

    /**
     * {@inheritdoc}
     */
    public function configureSettings(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'template' => 'ApplicationDefaultBundle:Redesign/Event:event.speakers.html.twig',
            'event' => null,
            'event_block' => null,
        ]);
    }
}